Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: refine cmd stream restore to restore log #33734

Merged
merged 10 commits into from
Apr 14, 2022
Merged

br: refine cmd stream restore to restore log #33734

merged 10 commits into from
Apr 14, 2022

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Apr 6, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #33795

Problem Summary:

  1. refine cmd stream restore to restore log
  2. hidden not support flags for new command stream.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

image

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 6, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YuJuncen
  • joccau

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 6, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 6, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/7159815b984cf20f6deee0e294b2d441bd786890

@3pointer 3pointer force-pushed the adjust_cmd_config branch from aa3cdde to 2a71e2d Compare April 6, 2022 11:49
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 7, 2022
@3pointer 3pointer marked this pull request as ready for review April 7, 2022 10:31
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2022
@joccau
Copy link
Member

joccau commented Apr 8, 2022

/cc @YuJuncen

@ti-chi-bot ti-chi-bot requested a review from YuJuncen April 8, 2022 01:19
@YuJuncen
Copy link
Contributor

YuJuncen commented Apr 8, 2022 

[2022-04-07T11:13:37.443Z] br/pkg/storage/azblob.go:57:18: Error return value of `flags.MarkHidden` is not checked (errcheck)
[2022-04-07T11:13:37.443Z] 	flags.MarkHidden(azblobEndpointOption)
[2022-04-07T11:13:37.443Z] 	                ^
[2022-04-07T11:13:37.443Z] br/pkg/storage/azblob.go:58:18: Error return value of `flags.MarkHidden` is not checked (errcheck)
[2022-04-07T11:13:37.443Z] 	flags.MarkHidden(azblobAccessTierOption)
[2022-04-07T11:13:37.443Z] 	                ^
[2022-04-07T11:13:37.443Z] br/pkg/storage/azblob.go:59:18: Error return value of `flags.MarkHidden` is not checked (errcheck)
[2022-04-07T11:13:37.443Z] 	flags.MarkHidden(azblobAccountName)

@joccau
Copy link
Member

joccau commented Apr 8, 2022

/cc @joccau PTAL

@ti-chi-bot ti-chi-bot requested a review from joccau April 8, 2022 07:41
@ti-chi-bot
Copy link
Member

@joccau: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @joccau PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

YuJuncen
YuJuncen approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 11, 2022
joccau
joccau reviewed Apr 11, 2022
View reviewed changes
Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

br/pkg/task/restore.go Outdated Show resolved Hide resolved
br/pkg/task/restore.go Outdated Show resolved Hide resolved
3pointer and others added 3 commits April 11, 2022 19:44
@3pointer @joccau
Update br/pkg/task/restore.go
4603102 
Co-authored-by: Zak Zhao <57036248+joccau@users.noreply.github.com>
@3pointer @joccau
Update br/pkg/task/restore.go
e12e4fc 
Co-authored-by: Zak Zhao <57036248+joccau@users.noreply.github.com>
@3pointer
Merge branch 'br-stream' into adjust_cmd_config
c3ed563
@ti-chi-bot ti-chi-bot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 11, 2022
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 11, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 11, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 11, 2022
@3pointer
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7159815

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 14, 2022
@3pointer 3pointer merged commit e8c87fd into pingcap:br-stream Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joccau joccau joccau approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@3pointer @ti-chi-bot @sre-bot @joccau @YuJuncen