Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: use the correct unit for pausing schedulers (#33545) #33813

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 8, 2022

cherry-pick #33545 to release-5.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/33813

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/33813:release-5.2-53042e7aab60

Signed-off-by: Ryan Leung rleungx@gmail.com

What problem does this PR solve?

Issue Number: close #33546.

Problem Summary: The unit for TTL of schedulers is not correct. We should use second as the unit.

What is changed and how it works?

Check List

Tests

  • Manual test
  1. start a cluster with TiUP
  2. use lightning to import data
  3. kill lightning with kill -9

Here is the log of PD:

[2022/03/29 14:26:07.097 +08:00] [INFO] [handler.go:272] ["pause scheduler successfully"] [scheduler-name=balance-region-scheduler] [pause-seconds=300]
[2022/03/29 14:26:07.097 +08:00] [INFO] [handler.go:272] ["pause scheduler successfully"] [scheduler-name=balance-leader-scheduler] [pause-seconds=300]
[2022/03/29 14:26:07.098 +08:00] [INFO] [handler.go:272] ["pause scheduler successfully"] [scheduler-name=balance-hot-region-scheduler] [pause-seconds=300]

Release note

Fix the issue that the schedulers won't be resumed after BR/Lightning exits abnormally.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 8, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 8, 2022
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 8, 2022
@ti-srebot ti-srebot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/5.2-cherry-pick labels Apr 8, 2022
@ti-srebot ti-srebot requested review from glorv and JmPotato April 8, 2022 06:38
@ti-srebot
Copy link
Contributor Author

@rleungx you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 11, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 11, 2022
@glorv
Copy link
Contributor

glorv commented Apr 11, 2022

@3pointer @YuJuncen PTAL at the CI failure:

[](https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/44253/pipeline#step-73-log-2)[](https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/44253/pipeline#step-73-log-3)[](https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/44253/pipeline#step-73-log-4)[](https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/44253/pipeline#step-73-log-5)[](https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/44253/pipeline#step-73-log-6)[](https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/44253/pipeline#step-73-log-7)[](https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/44253/pipeline#step-73-log-8)[2022-04-08T06:40:15.942Z] + ulimit -c unlimited

[2022-04-08T06:40:15.942Z] + export GOBACTRACE=crash

[2022-04-08T06:40:15.942Z] + GOBACTRACE=crash

[2022-04-08T06:40:15.942Z] + export log_level=warn

[2022-04-08T06:40:15.942Z] + log_level=warn

[2022-04-08T06:40:15.942Z] + make br_unit_test_in_verify_ci

[2022-04-08T06:40:15.942Z] make: *** No rule to make target `br_unit_test_in_verify_ci'.  Stop.

No test report files were found. Configuration error?

@VelocityLight
Copy link

This pull request is closed because it's related version has closed automatic cherry-picking.
If it's still needed, you can reopen it or just regenerate it using bot,
see:

You can find more details at:

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 21, 2022
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Nov 2, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/5.2-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants