ddl: fix duplicate elementID allocation to make sure gc work for partition table (#33726) #33856
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #33726 to release-5.4
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/33856
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #33620
Problem Summary:
We use partitionID or indexID as elementID sometimes.
When
drop index for partition table
, we use indexID as elementID. So we may miss some deleteRange.What is changed and how it works?
Allocate elementID as 1, 2, 3, 4 for a DDL job.
Besides, add a comment to log so that we can debug easier.
Check List
Tests
Side effects
Documentation
Release note