-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: fix lightning split large csv file error and adjust s3 seek result (#27769) #33883
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@glorv you're already a collaborator in bot's repo. |
/run-integration-br-test |
/hold |
@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This pull request is closed because it's related version has closed automatic cherry-picking. You can find more details at: |
cherry-pick #27769 to release-5.2
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/33883
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Fix the bug that lightning split large csv file may failed if the file size if slightly bigger the
region-split-size
and the csv has header.close #27763
What is changed and how it works?
io.EOF
makeTableRegions
, after preprocess the header line, if the remain file is smaller thanregion-split-size
, directly return the result with 1 region.Check List
Tests
Side effects
Documentation
Release note