Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: support keep pruned conds #34029

Merged
merged 19 commits into from
Apr 15, 2022
Merged

planner: support keep pruned conds #34029

merged 19 commits into from
Apr 15, 2022

Conversation

Reminiscent
Copy link
Contributor

What problem does this PR solve?

Issue Number: related to #33966

Problem Summary:
Add a switch to control whether keep the pruning conditions.

What is changed and how it works?

Add a switch to control whether keep the pruning conditions.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Reminiscent Reminiscent added the sig/planner SIG: Planner label Apr 15, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • time-and-fate
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 15, 2022
@Reminiscent Reminiscent changed the title planner: support keep pruning conds planner: support keep pruned conds Apr 15, 2022
chrysan
chrysan approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@chrysan chrysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@chrysan: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Reminiscent
Reminiscent commented Apr 15, 2022
View reviewed changes
sessionctx/variable/tidb_vars.go Outdated Show resolved Hide resolved
sessionctx/variable/tidb_vars.go Outdated Show resolved Hide resolved
sessionctx/variable/sysvar.go Outdated Show resolved Hide resolved
sessionctx/variable/sysvar.go Outdated Show resolved Hide resolved
sessionctx/variable/session.go Outdated Show resolved Hide resolved
planner/core/integration_test.go Outdated Show resolved Hide resolved
planner/core/integration_test.go Outdated Show resolved Hide resolved
sessionctx/variable/tidb_vars.go Show resolved Hide resolved
executor/set_test.go Outdated Show resolved Hide resolved
planner/core/integration_test.go Outdated Show resolved Hide resolved
Reminiscent
Reminiscent commented Apr 15, 2022
View reviewed changes
executor/set_test.go Outdated Show resolved Hide resolved
@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b15a2602d5958348448ffe14cc62895b62bc2267

winoros
winoros reviewed Apr 15, 2022
View reviewed changes
sessionctx/variable/tidb_vars.go Outdated
@@ -740,6 +743,7 @@ const (
DefTMPTableSize = 16777216
DefTiDBEnableLocalTxn = false
DefTiDBEnableOrderedResultMode = false
DefTiDBKeepPrunedConds = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format the space and tab?

@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 15, 2022
@winoros winoros added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Apr 15, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2022
@winoros
Copy link
Member

winoros commented Apr 15, 2022

/merge

@ti-chi-bot
Copy link
Member

@winoros: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 15, 2022
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b15a260

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2022
@winoros
Copy link
Member

winoros commented Apr 15, 2022

/run-unit-test

2 similar comments
@winoros
Copy link
Member

winoros commented Apr 15, 2022

/run-unit-test

@winoros
Copy link
Member

winoros commented Apr 15, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 7866626 into pingcap:release-5.2 Apr 15, 2022
@zhouqiang-cl zhouqiang-cl added this to the v5.2.4 milestone Apr 18, 2022
@purelind purelind mentioned this pull request Apr 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@winoros winoros winoros approved these changes

@chrysan chrysan chrysan approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. priority/release-blocker This issue blocks a release. Please solve it ASAP. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v5.2.4
Development

Successfully merging this pull request may close these issues.
9 participants
@Reminiscent @ti-chi-bot @sre-bot @winoros @hawkingrei @chrysan @time-and-fate @VelocityLight @zhouqiang-cl