Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: optimize the sharding algorithm for non-transactional DMLs #34050

Merged
merged 5 commits into from
Apr 18, 2022
Merged

session: optimize the sharding algorithm for non-transactional DMLs #34050

merged 5 commits into from
Apr 18, 2022

Conversation

ekexium
Copy link
Contributor

@ekexium ekexium commented Apr 17, 2022

Signed-off-by: ekexium ekexium@gmail.com

What problem does this PR solve?

Issue Number: ref #33485

Problem Summary:

Use an accurate sharding algorithm that makes the best effort to make the actual batch size equal to the batch size specified by the user.
Using the original algorithm, when there are duplicated values, the worst case can be a super large batch containing all values. The PR avoids such cases.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ekexium
optimize the sharding algorithm
762e830 
Signed-off-by: ekexium <ekexium@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • you06

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 17, 2022
@ekexium ekexium requested review from you06 and cfzjywxk April 17, 2022 16:29
@sre-bot
Copy link
Contributor

sre-bot commented Apr 17, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/5e097cf79ae06067959aca70dbb4a26540dde636

@ekexium
modify the test
bc4d966 
Signed-off-by: ekexium <ekexium@gmail.com>
you06
you06 reviewed Apr 18, 2022
View reviewed changes
Copy link
Contributor

@you06 you06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

session/nontransactional.go Show resolved Hide resolved
@ekexium
skip a chunk when it's can't be partitioned
0500390 
Signed-off-by: ekexium <ekexium@gmail.com>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 18, 2022
@ekexium
fix a bug
ec81234 
Signed-off-by: ekexium <ekexium@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 18, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 18, 2022
@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ec81234

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 18, 2022
@ekexium
Copy link
Contributor Author

ekexium commented Apr 18, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit e10ad28 into pingcap:master Apr 18, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 18, 2022

TiDB MergeCI notify

🔴 Bad News! [2] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 1, success 10, total 11 13 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 11, total 12 10 min Existing failure
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 19 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 6 min 30 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@you06 you06 you06 approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ekexium @ti-chi-bot @sre-bot @cfzjywxk @you06