Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: migrate test-infra to testify for tidbAsLibrarySuite #34178

Merged
merged 5 commits into from
Apr 27, 2022
Merged

session: migrate test-infra to testify for tidbAsLibrarySuite #34178

merged 5 commits into from
Apr 27, 2022

Conversation

tisonkun
Copy link
Contributor

Issue Number: ref #28328

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 24, 2022
@tisonkun
Copy link
Contributor Author

/cc @hawkingrei @xhebox

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 24, 2022
@ti-chi-bot ti-chi-bot requested review from hawkingrei and xhebox April 24, 2022 06:23
@sre-bot
Copy link
Contributor

sre-bot commented Apr 24, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/fb32d6911c8a08bf6f5e8ccfd3222ae57b8ff1cf

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 24, 2022
@tisonkun
Copy link
Contributor Author

@xhebox @bb7133 weird, testPessimisticSuite keep failing, while I think this patch should not touch them.

@tisonkun tisonkun requested a review from a team as a code owner April 27, 2022 03:01
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 27, 2022
@tisonkun
session: migrate test-infra to testify for tidbAsLibrarySuite
0eab76e 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 27, 2022
@tisonkun
debugging
92e8759 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 27, 2022
@disksing
Copy link
Contributor

seems you forgot to import pingcap/check.

tisonkun added 3 commits April 27, 2022 16:35
@tisonkun
fix import
3400add 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
fix compile
63114d2 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Merge branch 'master' into tidb-as-library
fb32d69
@tisonkun
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fb32d69

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 27, 2022
@ti-chi-bot ti-chi-bot merged commit a0f55d3 into pingcap:master Apr 27, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 27, 2022

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🔴 failed 2, success 10, total 12 9 min 37 sec Existing failure
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 15 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 15 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 9 min 37 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 41 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@tisonkun tisonkun deleted the tidb-as-library branch April 27, 2022 10:57
tisonkun
tisonkun commented Apr 27, 2022
View reviewed changes
session/tidb_library_test.go
)

func TestMemoryLeak(t *testing.T) {
t.Skip("hack")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's my fault to keep this line before clicking merge. Trying to re-enable it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@disksing disksing disksing approved these changes

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tisonkun @ti-chi-bot @sre-bot @disksing @xhebox