Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: refactor the code for ExecutePreparedStmt #34478

Closed
wants to merge 5 commits into from

Conversation

Reminiscent
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #32371

Problem Summary:
Remove the wrong handle logic in the ExecutePreparedStmt function. We don't need the fast path for the point get plan. We treat it as normal.

What is changed and how it works?

Remove the wrong handle logic in the ExecutePreparedStmt function.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Reminiscent Reminiscent added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels May 9, 2022
@Reminiscent Reminiscent requested a review from qw4990 May 9, 2022 07:35
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-6.0 size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 9, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 9, 2022

@Reminiscent
Copy link
Contributor Author

/run-build-arm64 comment=true

2 similar comments
@Reminiscent
Copy link
Contributor Author

/run-build-arm64 comment=true

@purelind
Copy link
Contributor

/run-build-arm64 comment=true

@sre-bot
Copy link
Contributor

sre-bot commented May 10, 2022

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2022
@ti-chi-bot
Copy link
Member

@Reminiscent: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plan Cache get wrong result when reuse the PointGet plan with null parameter
5 participants