Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PiTR: support empty schema in PiTR. #34551

Merged
merged 1 commit into from
May 11, 2022
Merged

Conversation

joccau
Copy link
Member

@joccau joccau commented May 10, 2022

Signed-off-by: joccau zak.zhao@pingcap.com

What problem does this PR solve?

Issue Number: ref #33866

Problem Summary:

What is changed and how it works?

Support empty schema in PiTR.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

test

  • backup steps

    • create empty schema emptydb
    • br backup full in up-stream
    • br log start in up-stream
    • create table emptydb.t and insert 1000 record.
  • restore steps 1

  • br restore point --full-backup-storage --s in down-stream. emptydb.t and records has been recovered.

  • restore steps 2

  • br restore full in down-stream

  • br restore point --start-ts --restore-ts in down-stream. emptydb.t and records has been recovered.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 10, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 10, 2022
@joccau
Copy link
Member Author

joccau commented May 10, 2022

/cc @3pointer @YuJuncen PTAL

@ti-chi-bot ti-chi-bot requested review from 3pointer and YuJuncen May 10, 2022 15:57
@ti-chi-bot
Copy link
Member

@joccau: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @3pointer @YuJuncen PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joccau
Copy link
Member Author

joccau commented May 11, 2022

/run-unit-test

Signed-off-by: joccau <zak.zhao@pingcap.com>
@joccau joccau force-pushed the br-stream-build branch from ac24bdf to 4de3284 Compare May 11, 2022 04:29
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 11, 2022
@3pointer 3pointer merged commit f894c48 into pingcap:br-stream May 11, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 11, 2022

@joccau joccau deleted the br-stream-build branch May 12, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants