Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix show database like case sensitive issue#34766 #34925

Merged
merged 6 commits into from
May 30, 2022

Conversation

e1ijah1
Copy link
Contributor

@e1ijah1 e1ijah1 commented May 24, 2022

Signed-off-by: elijah f1renze.142857@gmail.com

What problem does this PR solve?

Issue Number: close #34766

Problem Summary: show database like should not be case sensitive

What is changed and how it works?

add a filter plannercore.ShowDatabaseExtractor in the ShowExec. It will bring the like expression to the place where to get meta and filter them for getting the right result.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
MySQL root@(none):(none)> CREATE DATABASE `TEST_$1`;
Query OK, 1 row affected
Time: 0.002s
MySQL root@(none):(none)> CREATE DATABASE `test_$2`;
Query OK, 1 row affected
Time: 0.001s
MySQL root@(none):(none)> SHOW DATABASES LIKE "TEST_%";
+------------------+
| Database (TEST%) |
+------------------+
| TEST_$1          |
| test_$2          |
+------------------+

2 rows in set
Time: 0.014s
MySQL root@(none):(none)> SHOW DATABASES LIKE "test_%";
+------------------+
| Database (test%) |
+------------------+
| TEST_$1          |
| test_$2          |
+------------------+
2 rows in set
Time: 0.008s
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

executor: fix show database like case sensitive issue

Signed-off-by: elijah <f1renze.142857@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 24, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 24, 2022
@hawkingrei hawkingrei self-requested a review May 24, 2022 16:29
@sre-bot
Copy link
Contributor

sre-bot commented May 24, 2022

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2022
@e1ijah1
Copy link
Contributor Author

e1ijah1 commented May 27, 2022

/run-mysql-test

@e1ijah1
Copy link
Contributor Author

e1ijah1 commented May 27, 2022

/run-check_title

executor/show.go Outdated Show resolved Hide resolved
e1ijah1 added 2 commits May 30, 2022 13:17
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 30, 2022
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 96441d7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 30, 2022
@ti-chi-bot ti-chi-bot merged commit b3d7a8e into pingcap:master May 30, 2022
@hawkingrei
Copy link
Member

/cherry-pick release-6.1

@hawkingrei hawkingrei added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label May 31, 2022
@hawkingrei
Copy link
Member

/run-cherry-picker

@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #35060

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 31, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Aug 20, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🔴 all 6 tests passed 6 min 13 sec Existing failure
idc-jenkins-ci/integration-cdc-test ✅ all 36 tests passed 33 min Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 7 min 54 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 53 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 25 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 13 tests passed 4 min 23 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 45 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 5 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SHOW DATABASES LIKE should be case insensitive
6 participants