executor: do not append extra cols to the old row when updateDupRow
(#33656)
#35163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #33656 to release-5.2
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/35163
After apply modifications, you can push your change to this PR via:
Signed-off-by: zyguan zhongyangguan@gmail.com
What problem does this PR solve?
Issue Number: close #33608
Problem Summary:
What is changed and how it works?
We append extra datums to the old row to resolve #14164 , however it breaks binlog. We need to prevent binlogRow from including those extra datums. This PR keep the old row unchanged and pass the extra cols info to
doDupRowUpdate
.Check List
Tests
Side effects
Documentation
Release note