Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add batch_point_get access object #35230

Merged
merged 34 commits into from
Jun 21, 2022
Merged

planner: add batch_point_get access object #35230

merged 34 commits into from
Jun 21, 2022

Conversation

ymkzpx
Copy link
Contributor

@ymkzpx ymkzpx commented Jun 8, 2022

What problem does this PR solve?

Issue Number: close #32815

Problem Summary:

above.

What is changed and how it works?

Check List

  • Unit test

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory

Release note

None.

ymkzpx and others added 13 commits May 30, 2022 21:11
@ymkzpx
Add more warnings to inform the user that setting TiDB partition prun…
b47ab9a 
…e mode to dynamic at session level
@ymkzpx @bb7133
Update table/tables/partition_test.go
721ce31 
Co-authored-by: bb7133 <bb7133@gmail.com>
@ymkzpx
Merge branch 'master' of github.com:pingcap/tidb into partition-prune…
0a4a07c 
…-mode-session-level
@ymkzpx
Merge branch 'partition-prune-mode-session-level' of github.com:littl…
cd3cda7 
…elittlehorse/tidb into partition-prune-mode-session-level
@ymkzpx
update
e6baea4
@ymkzpx
Merge branch 'master' of github.com:pingcap/tidb into batch_point_get…
143df62 
…-access-object
@ymkzpx
Add batch_point_get access object
61f2163
@ymkzpx
fix
091c69a
@ymkzpx
Merge branch 'master' of github.com:pingcap/tidb into batch_point_get…
475bb31 
…-access-object
@ymkzpx
fix
2d218db
@ymkzpx
fix
ee17f7a
@ymkzpx
Merge branch 'master' of github.com:pingcap/tidb into batch_point_get…
d76e801 
…-access-object
@ymkzpx
refator BatchPointGet accessObject
7da02c4
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • mjonss

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 8, 2022
@ymkzpx ymkzpx changed the title Batch point get access object planner: add batch_point_get access object Jun 8, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 8, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@ymkzpx
Copy link
Contributor Author

ymkzpx commented Jun 8, 2022

/run-check_title

@ymkzpx
Copy link
Contributor Author

ymkzpx commented Jun 8, 2022

/run-unit-test

1 similar comment
@ymkzpx
Copy link
Contributor Author

ymkzpx commented Jun 8, 2022

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Jun 10, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/cdd75ebd7e52cb3a1bf45486f85769d1d0087322

@ymkzpx ymkzpx requested review from bb7133 and mjonss June 17, 2022 08:11
@ymkzpx
Copy link
Contributor Author

ymkzpx commented Jun 19, 2022

/run-unit-test

@ymkzpx
Copy link
Contributor Author

ymkzpx commented Jun 20, 2022

/run-check_dev

@ymkzpx
Copy link
Contributor Author

ymkzpx commented Jun 20, 2022

/run-unit-test

bb7133
bb7133 approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 20, 2022
mjonss
mjonss approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some suggested improvements to the tests.

planner/core/point_get_plan_test.go Outdated Show resolved Hide resolved
planner/core/point_get_plan_test.go Outdated Show resolved Hide resolved
planner/core/point_get_plan_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 20, 2022
@ymkzpx
Copy link
Contributor Author

ymkzpx commented Jun 21, 2022

/merge

@ti-chi-bot
Copy link
Member

@ymkzpx: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@mjonss
Copy link
Contributor

mjonss commented Jun 21, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: aa4573a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 21, 2022
@mjonss
Copy link
Contributor

mjonss commented Jun 21, 2022

/run-realtikv-test

1 similar comment
@ymkzpx
Copy link
Contributor Author

ymkzpx commented Jun 21, 2022

/run-realtikv-test

@mjonss
Copy link
Contributor

mjonss commented Jun 21, 2022

/run-all-tests

@hawkingrei
Copy link
Member

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 6cefaa9 into pingcap:master Jun 21, 2022
morgo added a commit to morgo/tidb that referenced this pull request Jun 28, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into kill-ddl
afde8a8 
* upstream/master:
  sessionctx: support encoding and decoding session variables (pingcap#35531)
  planner: add batch_point_get access object (pingcap#35230)
  sessionctx: set skipInit false for TiDBOptProjectionPushDown and TiDBOptAggPushDown (pingcap#35491)
  *: add support for disabling noop variables (pingcap#35496)
  lightning: add store write limiter (pingcap#35193)
  expression: avoid padding 0 when implicitly cast to binary (pingcap#35053)
  types: fix creating partition tables fail in ANSI_QUOTES mode (pingcap#35379)
  executor: add the missed runtime stats when the index merge partial task returns 0 row (pingcap#35297)
  statistics: batch insert topn and bucket when saving table stats (pingcap#35326)
  parser: Add support for INTERVAL expr unit + expr (pingcap#30253) (pingcap#35390)
  config: add missing nodelay example (pingcap#35255)
  *: Introduce `OptimisticTxnContextProvider` for optimistic txn (pingcap#35131)
  statistics: fix panic when using wrong globalStats.Indices key (pingcap#35424)
  *: fix store token is up to the limit in test (pingcap#35374)
  *: enable more flaky and update bazel config (pingcap#35500)
  ddl: expose getPrimaryKey() as a public method of model.TableInfo (pingcap#35512)
  expression, util: add `KeyWithoutTrimRightSpace` for collator (pingcap#35475)
  infoschema: try on each PD member until one succeeds or all fail (pingcap#35285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjonss mjonss mjonss approved these changes

@bb7133 bb7133 bb7133 approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explain for Batch_Point_Get does not include partition information in access object
6 participants
@ymkzpx @ti-chi-bot @sre-bot @mjonss @hawkingrei @bb7133