privilege: limit the privileges in memory schemas (#35260) #35331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #35260 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/35331
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #35205
Problem Summary:
In the previous implementation,
metrics_schema.t
isn't one of the metrics tables, so the privilege checker is skipped. However, because the memory databases are not persist in storage, DDL hangs because of "database not exists" error.What is changed and how it works?
This PR disallows users run
CREATE/ALTER/DROP/INSERT/UPDATE/DELETE
statements on any tables in memory databases.Check List
Tests
Side effects
After this PR, the following operations on memory tables are not supported anymore:
information_schema
:REFERENCES
,EXECUTE
,SHOW VIEW
,LOCK TABLES
.performance_schema
:CREATE
,LOCK TABLES
.metrics_schema
:CREATE
,CREATE VIEW
.REFERENCES
,EXECUTE
,SHOW VIEW
,LOCK TABLES
.Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.