-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: batch insert topn and bucket when saving table stats (#35326) #35545
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/run-all-tests |
@xuyifangreeneyes you're already a collaborator in bot's repo. |
This pull request is closed because it's related version has closed automatic cherry-picking. You can find more details at: |
cherry-pick #35326 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/35545
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: ref #35142
Problem Summary:
Analyze partition table is slower than analyze non-partition table with the same amount of data.
What is changed and how it works?
In
SaveTableStatsToStorage
, we execute one insert statement for each topn and each bucket so there are too many insertions in the transaction and make the function time-consuming. The PR batches insertions for topn and bucket and makeSaveTableStatsToStorage
more efficient.Check List
Tests
For a table with 40 million rows and 20 partitions, analyze takes 9min and
SaveTableStatsToStorage
for one partition takes 21s. After the PR, analyze takes 3min andSaveTableStatsToStorage
for one partition takes 4s.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.