Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: introduce new cost formula for MPPJoins #35643

Merged
merged 8 commits into from
Jun 22, 2022
Merged

planner: introduce new cost formula for MPPJoins #35643

merged 8 commits into from
Jun 22, 2022

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jun 22, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #35240

Problem Summary: planner: introduce new cost formula for MPPJoins

What is changed and how it works?

On modelVer2, use the dedicated TiFlash CPU factor for MPPJoins(HashJoin).
Since all MPPJoins(BCJ, ShuffleHJ, ...) are implemented by HashJoin, so we only need to modify HashJoin in this PR.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • Reminiscent

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 22, 2022
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 22, 2022
@qw4990 qw4990 added the sig/planner SIG: Planner label Jun 22, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 22, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/a44f9a295903c3c64e178bf2de56b2acc7b7b798

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 22, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 22, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 22, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0edff50

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 22, 2022

/merge

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 22, 2022

/merge

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 22, 2022

/merge

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 22, 2022

/merge

@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot merged commit 56d004e into pingcap:master Jun 22, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 22, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 35 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 17 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 31 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 2 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 48 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 21 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 50 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 30 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

qw4990 added a commit to qw4990/tidb that referenced this pull request Jul 12, 2022
@qw4990
planner: introduce new cost formula for MPPJoins (pingcap#35643)
350e8ac 
ref pingcap#35240
@qw4990 qw4990 mentioned this pull request Jul 12, 2022
Merged
qw4990 added a commit that referenced this pull request Jul 12, 2022
@qw4990
planner: introduce new cost formula for MPPJoins (#35643) (#36134)
d2d423b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent approved these changes

@AilinKid AilinKid AilinKid approved these changes

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qw4990 @ti-chi-bot @sre-bot @Reminiscent @AilinKid