sessionctx/variable: add tests to ensure skipInit can be removed #35703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/f7bb1683d8b927b11b4788cd2cc7fbb02c107cfd |
xhebox
approved these changes
Jun 24, 2022
hawkingrei
approved these changes
Jun 26, 2022
ti-chi-bot
added
status/LGT2
|
This pull request has been accepted and is ready to merge. Commit hash: 24a5e17
|
ti-chi-bot
added
the
status/can-merge
|
/hold Waiting for configuration reviewer, ping @bb7133 |
ti-chi-bot
added
the
do-not-merge/hold
|
/run_check_dev_2 |
bb7133
approved these changes
Jun 28, 2022
|
/merge |
|
/unhold |
ti-chi-bot
removed
the
do-not-merge/hold
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
morgo
added a commit
to morgo/tidb
that referenced
this pull request
Jun 28, 2022
* upstream/master: (57 commits) types: fix incompatible implementation of jsonpath extraction (pingcap#35320) planner: fix TRACE PLAN TARGET = 'estimation' panic when meeting partition table (pingcap#35743) *: Add `testfork.RunTest` to run multiple tests in one function (pingcap#35746) sessionctx/variable: add tests to ensure skipInit can be removed (pingcap#35703) helper: request another PD if one of them is unavailable (pingcap#35750) metrics: add cached table related metrics to grafana panel (pingcap#34718) expression: use cloned RetType at `evaluateExprWithNull` when it may be changed. (pingcap#35759) executor: fix left join on partition table generate invalid lock key (pingcap#35732) readme: remove adopters (pingcap/docs#8725) (pingcap#35124) *: only add default value for final aggregation to fix the aggregate push down (partition) union case (pingcap#35443) planner: fix the wrong cost formula of MPPExchanger on cost model ver2 (pingcap#35718) sessionctx: support encoding and decoding statement context (pingcap#35688) txn: refactor ts acquisition within build and execute phases (pingcap#35376) ddl: for schema-level DDL method parameter is now XXXStmt (pingcap#35722) *: enable gofmt (pingcap#35721) planner: disable collate clause support for enum or set column (pingcap#35684) *: Provide a util to "pause" session in uint test (pingcap#35529) ddl: implement the core for multi-schema change (pingcap#35429) parser: XXXDatabaseStmt now use CIStr for DB name (pingcap#35668) *: remove real tikv test on github actions (pingcap#35710) ...
morgo
added a commit
to morgo/tidb
that referenced
this pull request
Jun 29, 2022
…vars * upstream/master: (28 commits) *: enable unconvert (pingcap#35821) log-backup: check timezone when using datatime format ts string (pingcap#35811) planner: support the leading hint for outer join (pingcap#35264) lightning: revert new policy of allocating rowid and refine it later (pingcap#35817) txn: manage the initialization of RCCheckTS by transaction context provider (pingcap#35554) ddl: make output field name in `show tables/databases stmt` compatible with mysql (pingcap#35136) txn: remove `legacy.SimpleTxnContextProvider` (pingcap#35667) txn: fix the error message if retry could not be used for rc check ts (pingcap#35474) *: support canceling DDL statements with KILL (pingcap#35803) lightning: avoid extracting db schema when schema file is not provided (pingcap#35783) *: enable all gosimples (pingcap#35762) tools/check: skip 'tests' directory in 'make ut' (pingcap#35800) metrics: add loading region cache duration (pingcap#34679) ddl: DROP TABLE/VIEW/SEQUENCE now use XXXStmt as parameter (pingcap#35741) types: fix incompatible implementation of jsonpath extraction (pingcap#35320) planner: fix TRACE PLAN TARGET = 'estimation' panic when meeting partition table (pingcap#35743) *: Add `testfork.RunTest` to run multiple tests in one function (pingcap#35746) sessionctx/variable: add tests to ensure skipInit can be removed (pingcap#35703) helper: request another PD if one of them is unavailable (pingcap#35750) metrics: add cached table related metrics to grafana panel (pingcap#34718) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #35051
Problem Summary:
The skipInit feature is left over from a refactor. The problem is, the usage of it has actually increased :(
What is changed and how it works?
This is a change to tests only to ensure no new variables are introduced with skipInit.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.