Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

table partition: exchange partition with table enhance #35749

Merged
merged 58 commits into from
Jul 20, 2022
Merged

table partition: exchange partition with table enhance #35749

merged 58 commits into from
Jul 20, 2022

Conversation

ymkzpx
Copy link
Contributor

@ymkzpx ymkzpx commented Jun 27, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #35996

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains experimental features

Release note

exchange partition with table GA.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • mjonss
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 27, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 6, 2022
@ymkzpx ymkzpx changed the title table partition: exchange partition with table GA table partition: exchange partition with table enhance Jul 7, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 7, 2022
@mjonss mjonss self-requested a review July 7, 2022 07:34
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 11, 2022
@bb7133
Copy link
Member

bb7133 commented Jul 19, 2022

I saw that the CI is not stable, but I guess this is not related to this PR.

@bb7133
Copy link
Member

bb7133 commented Jul 19, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ae31db1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 19, 2022
bb7133
bb7133 reviewed Jul 20, 2022
View reviewed changes
ddl/partition.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2022
@ymkzpx
Copy link
Contributor Author

ymkzpx commented Jul 20, 2022

/run-unit-test

1 similar comment
@ymkzpx
Copy link
Contributor Author

ymkzpx commented Jul 20, 2022

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Jul 20, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9d6919c45443940d8fd1f893fb4169f7b535957c

@bb7133
Copy link
Member

bb7133 commented Jul 20, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f20d64d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2022
@ti-chi-bot ti-chi-bot merged commit e9f3980 into pingcap:master Jul 20, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 20, 2022

TiDB MergeCI notify

🔴 Bad News! [2] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 34, success 2, total 36 1 hr 11 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 1, success 10, total 11 49 min Existing failure
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 17 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 7 min 36 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 16 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 16 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 13 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 22 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 3 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@lcwangchao lcwangchao mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@mjonss mjonss mjonss approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

table partition: exchange partition with table enhance
6 participants
@ymkzpx @ti-chi-bot @bb7133 @sre-bot @tiancaiamao @mjonss