executor: fix left join on partition table generate invalid lock key (#35732)

[ti-srebot]

cherry-pick #35732 to release-6.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/35773

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/35773:release-6.0-82f0faf78a6d

---

What problem does this PR solve?

Issue Number: close #28073

Problem Summary:

select * from t1 left join t2 ... for update
t2 is partition table.

In the left join case, the physical column id might be 0,
because when a row in t1 but not in t2, NULL will be filled...
and the physical column ID is not set in the row.

It cause the for update generate the invalid lock key with physical ID = 0

What is changed and how it works?

Skip the physical ID = 0 lock key to avoid that case.

Check List

Tests

• Unit test

By the way, I find something seems wrong:

• kv storage Scan() API seems don't scan the lock CF... (I'm not sure is it by design? there is also a ScanLock() API used by the GCWorker)

• We should use 'begin pessimistic' in the test so the lock key is written before the transaction commit. In optimistic txn mode, the lock key is buffered and written until commit... then the test code can't read that lock

• Integration test

• Manual test (add detailed scripts or steps below)

• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[ti-chi-bot]

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-srebot]

/run-all-tests

[ti-srebot]

@tiancaiamao you're already a collaborator in bot's repo.

[xhebox]

closed for DMR version