Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: cache pathExpression to improve the JSON function performance #35860

Merged
merged 7 commits into from
Jul 1, 2022
Merged

types: cache pathExpression to improve the JSON function performance #35860

merged 7 commits into from
Jul 1, 2022

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Jun 30, 2022 •
edited
Loading

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

What problem does this PR solve?

Issue Number: close #35859

Problem Summary:

Cache the pathExpression.

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

origin_img_v2_4b93a6c7-4456-4ebe-ba33-88ab6908024g
origin_img_v2_0fc77352-53f8-412c-96c3-f2fecd31f0eg
It shows that this PR has 5X performance improvement.

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

cache pathExpression to improve the JSON function performance

@wjhuang2016
done
1fd484f 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 30, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 30, 2022
winoros
winoros reviewed Jun 30, 2022
View reviewed changes
types/json/path_expr.go
@@ -261,3 +295,7 @@ func (pe PathExpression) String() string {
}
return s.String()
}

func init() {
peCache.cache = kvcache.NewSimpleLRUCache(1000, 0.1, math.MaxUint64)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set the quota to a value like 10MB?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has example code in the convertReadableSizeToByteSize. just some const value.

@wjhuang2016
fix cycle_reference
5d6715c 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
set capability to 10M
9113c4b 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
Revert "set capability to 10M"
f8b8f27 
This reverts commit 9113c4b.
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 30, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 1, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/372b8984ad3cdc3ebf6f18f33bfd5ac326bc907c

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 1, 2022
@xhebox
Copy link
Contributor

xhebox commented Jul 1, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7a9a057

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 1, 2022
@ti-chi-bot ti-chi-bot merged commit b18ee06 into pingcap:master Jul 1, 2022
@wjhuang2016 wjhuang2016 deleted the cache_pe branch November 17, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@xhebox xhebox xhebox approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cache PathExpression to improve the performance of JSON function
6 participants
@wjhuang2016 @ti-chi-bot @sre-bot @xhebox @hawkingrei @winoros