Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: add index acceleration implement #35984

Closed
wants to merge 16 commits into from
Closed

ddl: add index acceleration implement #35984

wants to merge 16 commits into from

Conversation

Benjamin2037
Copy link
Collaborator

@Benjamin2037 Benjamin2037 commented Jul 6, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #35983
Problem Summary:
This is used to implement add index acceleration feature.

What is changed and how it works?

it will use a Lightning to accelerate backfill processing for create index statement.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Benjamin2037 Benjamin2037 requested a review from a team as a code owner July 6, 2022 08:48
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 6, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 6, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@Benjamin2037 Benjamin2037 changed the title Add index lightning dev branch DDL:Add index acceleration implement Jul 6, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 6, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@Benjamin2037 Benjamin2037 changed the title DDL:Add index acceleration implement ddl: Add index acceleration implement Jul 6, 2022
@Benjamin2037 Benjamin2037 changed the title ddl: Add index acceleration implement ddl: add index acceleration implement Jul 6, 2022
@Benjamin2037 Benjamin2037 force-pushed the add_index_lightning_dev_branch branch 7 times, most recently from 7a9ca36 to fdd94a7 Compare July 7, 2022 06:49
@Benjamin2037 Benjamin2037 force-pushed the add_index_lightning_dev_branch branch 6 times, most recently from 4f7431a to 9058e60 Compare July 7, 2022 08:02
@Benjamin2037
Copy link
Collaborator Author

/run-mysql-test

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2022
@Benjamin2037 Benjamin2037 force-pushed the add_index_lightning_dev_branch branch from 061b282 to a4b74c8 Compare July 12, 2022 16:42
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2022
@Benjamin2037 Benjamin2037 force-pushed the add_index_lightning_dev_branch branch from a4b74c8 to bdd3936 Compare July 13, 2022 01:53
@dbsid dbsid mentioned this pull request Jul 13, 2022
Closed
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2022
@ti-chi-bot
Copy link
Member

@Benjamin2037: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Benjamin2037 Benjamin2037 force-pushed the add_index_lightning_dev_branch branch from 149148d to 59d6ef7 Compare July 14, 2022 01:54
@Benjamin2037
Copy link
Collaborator Author

/run-unit-test

@zimulala
Copy link
Contributor

/run-build-arm64 comment=true

@sre-bot
Copy link
Contributor

sre-bot commented Jul 14, 2022

download tidb binary(linux arm64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tidb/59d6ef7dd2bc3fa80e9f896045e3b479e02b9760/centos7/tidb-linux-arm64.tar.gz

@tangenta
Copy link
Contributor

tangenta commented Aug 1, 2022

The latest feature branch: #36767.

@tangenta tangenta closed this Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 Awaiting requested review from bb7133

@zimulala zimulala Awaiting requested review from zimulala

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

@Defined2014 Defined2014 Awaiting requested review from Defined2014

@xiongjiwei xiongjiwei Awaiting requested review from xiongjiwei

@tangenta tangenta Awaiting requested review from tangenta

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Benjamin2037 @ti-chi-bot @sre-bot @zimulala @tangenta @knull-cn