Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix return type of agg func bit_or when handling varbinary column (#36415) #36469

Merged
merged 1 commit into from
Jul 22, 2022
Merged

expression: fix return type of agg func bit_or when handling varbinary column (#36415) #36469

merged 1 commit into from
Jul 22, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jul 22, 2022 •
edited
Loading

cherry-pick #36415 to release-6.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/36469

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/36469:release-6.2-61175e8a4d56

What problem does this PR solve?

Issue Number: close #36400

Problem Summary:

What is changed and how it works?

  • make type cast to int explicit when using bit_or, bit_and, bit_xor

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@solotzg @ti-srebot
cherry pick pingcap#36415 to release-6.2
736738d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 22, 2022
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 22, 2022
@ti-srebot ti-srebot mentioned this pull request Jul 22, 2022
Merged
12 tasks
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/6.2-cherry-pick labels Jul 22, 2022
@ti-srebot
Copy link
Contributor Author

@solotzg you're already a collaborator in bot's repo.

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 22, 2022
zanmato1984
zanmato1984 approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 22, 2022
@solotzg
Copy link
Contributor

solotzg commented Jul 22, 2022

/run-unit-test

@solotzg
Copy link
Contributor

solotzg commented Jul 22, 2022

/run-integration-copr-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 22, 2022
@zanmato1984
Copy link
Contributor

/run-unit-test

@zanmato1984
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 736738d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 22, 2022
@zanmato1984
Copy link
Contributor

/run-unit-test

@zanmato1984
Copy link
Contributor

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Jul 22, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/736738dc992e7671dd48fd92465722ea68301b5e

@ti-chi-bot ti-chi-bot merged commit 08e450c into pingcap:release-6.2 Jul 22, 2022
@zanmato1984 zanmato1984 deleted the release-6.2-61175e8a4d56 branch July 22, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@guo-shaoge guo-shaoge Awaiting requested review from guo-shaoge

Assignees

@solotzg solotzg

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/6.2-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @ti-chi-bot @solotzg @zanmato1984 @sre-bot @XuHuaiyu @VelocityLight