Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: prevent sending cop request for show columns #36613

Merged
merged 9 commits into from
Jul 27, 2022
Merged

executor: prevent sending cop request for show columns #36613

merged 9 commits into from
Jul 27, 2022

Conversation

tangenta
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #36426, #36496

What is changed and how it works?

This PR prevents running the executor when executing SHOW COLUMNS or reading INFORMATION_SCHEMA.COLUMNS.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xhebox
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-6.2 size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 27, 2022
@tangenta tangenta mentioned this pull request Jul 27, 2022
Closed
12 tasks
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 27, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/d2e67e06691fcd3da9bbf2aee2fc38c3d35cd1e3

@tangenta tangenta requested a review from xhebox July 27, 2022 09:41
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 27, 2022
@tangenta
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 70a3e4f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 27, 2022
@ti-chi-bot ti-chi-bot merged commit e39ef4c into pingcap:master Jul 27, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 27, 2022
@ti-srebot
cherry pick pingcap#36613 to release-6.1
9a68a94 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 27, 2022
Merged
12 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Jul 27, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 6 min 23 sec Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 51 min Existing passed
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 26 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 18 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 37 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 37 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 14 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 23 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 5 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

ti-chi-bot pushed a commit that referenced this pull request Jul 28, 2022
@ti-srebot
executor: prevent sending cop request for show columns (#36613) (#36630)
c94307f 
close #36426, ref #36496
ti-chi-bot pushed a commit that referenced this pull request Aug 2, 2022
@ti-srebot
executor: prevent sending cop request for show columns (#36613) (#36629)
392a844 
close #36426, ref #36496
@xiongjiwei
Copy link
Contributor

/run-cherry-pick

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 2, 2022
@ti-srebot
cherry pick pingcap#36613 to release-5.2
cce8384 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 2, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #36816

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 2, 2022
@ti-srebot
cherry pick pingcap#36613 to release-5.4
d93288d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 2, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #36817

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 2, 2022
@ti-srebot
cherry pick pingcap#36613 to release-5.1
e602c8e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 2, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #36818

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 2, 2022
@ti-srebot
cherry pick pingcap#36613 to release-5.3
e5d47f0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 2, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #36819

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 2, 2022
@ti-srebot
cherry pick pingcap#36613 to release-5.0
b7e2e03 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 2, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #36820

ti-chi-bot pushed a commit that referenced this pull request Aug 10, 2022
@ti-srebot
executor: prevent sending cop request for show columns (#36613) (#36818)
533b81a 
close #36426, ref #36496
ti-chi-bot pushed a commit that referenced this pull request Aug 10, 2022
@ti-srebot
executor: prevent sending cop request for show columns (#36613) (#36819)
6c70b69 
close #36426, ref #36496
ti-chi-bot pushed a commit that referenced this pull request Aug 10, 2022
@ti-srebot
executor: prevent sending cop request for show columns (#36613) (#36820)
14066b2 
close #36426, ref #36496
ti-chi-bot pushed a commit that referenced this pull request Aug 10, 2022
@ti-srebot
executor: prevent sending cop request for show columns (#36613) (#36817)
77f7f9d 
close #36426, ref #36496
ti-chi-bot pushed a commit that referenced this pull request Aug 10, 2022
@ti-srebot
executor: prevent sending cop request for show columns (#36613) (#36816)
cd95bba 
close #36426, ref #36496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@qw4990 qw4990 qw4990 approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

show columns from view error
8 participants
@tangenta @ti-chi-bot @sre-bot @ti-srebot @xiongjiwei @xhebox @qw4990 @hawkingrei