Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: enhance the output infomation (#36676) #36706

Merged
merged 2 commits into from
Jul 29, 2022
Merged

br: enhance the output infomation (#36676) #36706

merged 2 commits into from
Jul 29, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jul 29, 2022 •
edited
Loading

cherry-pick #36676 to release-6.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/36706

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/36706:release-6.2-7a47538f4e52

Signed-off-by: joccau zak.zhao@pingcap.com

What problem does this PR solve?

Issue Number: ref #29501

Problem Summary:

What is changed and how it works?

Enhance the output about br restore point

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Manual test

[2022/07/28 20:15:56.389 +08:00] [INFO] [collector.go:69] ["restore log success summary"] [total-take=2.893277834s] [restore-from=434846695190167553] [restore-to=434847089271504897] [restore-from="2022-07-26 12:08:19.108 +0800"] [restore-to="2022-07-26 12:33:22.409 +0800"] [total-kv-count=13] [total-size=12.9kB] [average-speed=4.46kB/s]

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 29, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • YuJuncen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 29, 2022
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 29, 2022
@ti-srebot ti-srebot mentioned this pull request Jul 29, 2022
Merged
12 tasks
@ti-srebot ti-srebot added component/br This issue is related to BR of TiDB. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/6.2-cherry-pick labels Jul 29, 2022
@ti-srebot ti-srebot requested review from 3pointer and YuJuncen July 29, 2022 06:09
@ti-srebot
Copy link
Contributor Author

@joccau you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 29, 2022
@joccau joccau force-pushed the release-6.2-7a47538f4e52 branch from c67ffea to 29fc037 Compare July 29, 2022 06:19
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 29, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 29, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 29, 2022
@joccau joccau force-pushed the release-6.2-7a47538f4e52 branch from 29fc037 to 830d3f1 Compare July 29, 2022 06:29
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 29, 2022
@3pointer
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9905d79

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 29, 2022
@3pointer
Copy link
Contributor

/rebuild

@sre-bot
Copy link
Contributor

sre-bot commented Jul 29, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9905d79e417068d99f9de95600dd0cc97a7416bc

@ti-chi-bot ti-chi-bot merged commit edab299 into pingcap:release-6.2 Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

@3pointer 3pointer 3pointer approved these changes

Assignees

@joccau joccau

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/br This issue is related to BR of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/6.2-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @ti-chi-bot @3pointer @sre-bot @YuJuncen @VelocityLight @joccau