Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix inaccurate row_count for admin show ddl jobs #36716

Merged
merged 11 commits into from
Aug 1, 2022
Merged

ddl: fix inaccurate row_count for admin show ddl jobs #36716

merged 11 commits into from
Aug 1, 2022

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Jul 29, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #25968

Problem Summary: you could get information from #25968 (comment)

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix inaccuate row_count num

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 29, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 29, 2022
hawkingrei and others added 2 commits July 29, 2022 16:57
@hawkingrei
enable revive
34f2aab 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@Defined2014
Merge branch 'master' into fix-25968
13a8ffa
@Defined2014
Copy link
Contributor Author

/run-build

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 29, 2022
@Defined2014 Defined2014 changed the title ddl: fix inaccurate row_count for admin show ddl jobs [WIP] ddl: fix inaccurate row_count for admin show ddl jobs Jul 31, 2022
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 1, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/6e41377ec0486fad97f92fc956bc764fe8550676

@Defined2014 Defined2014 changed the title [WIP] ddl: fix inaccurate row_count for admin show ddl jobs ddl: fix inaccurate row_count for admin show ddl jobs Aug 1, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2022
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 1, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2022
@Defined2014 Defined2014 requested a review from crazycs520 August 1, 2022 06:50
zimulala
zimulala reviewed Aug 1, 2022
View reviewed changes
ddl/backfilling.go Outdated Show resolved Hide resolved
ddl/backfilling.go Outdated Show resolved Hide resolved
Defined2014 and others added 2 commits August 1, 2022 15:46
@Defined2014 @zimulala
Update ddl/backfilling.go
d01952a 
Co-authored-by: Lynn <zimu_xia@126.com>
@Defined2014 @zimulala
Update ddl/backfilling.go
822659d 
Co-authored-by: Lynn <zimu_xia@126.com>
@Defined2014
Copy link
Contributor Author

Done, @zimulala PTAL

zimulala
zimulala approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 1, 2022
@Defined2014
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1412bad

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 1, 2022
@Defined2014
Copy link
Contributor Author

/run-check_dev

@ti-chi-bot ti-chi-bot merged commit 93a31f0 into pingcap:master Aug 1, 2022
@Defined2014 Defined2014 deleted the fix-25968 branch August 1, 2022 08:40
morgo pushed a commit to morgo/tidb that referenced this pull request Aug 1, 2022
@Defined2014 @morgo
ddl: fix inaccurate row_count for admin show ddl jobs (pingcap#36716)
2addd42 
close pingcap#25968
morgo added a commit to morgo/tidb that referenced this pull request Aug 1, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into sysvar-api-cleanup
a462ff1 
* upstream/master:
  ddl/schematracker: fix SetDDL will cause data race (pingcap#36768)
  planner: check virtual column for tiflash (pingcap#36771)
  *: replace defer clean with t.Cleanup (pingcap#36722)
  ddl: fix inaccurate row_count for `admin show ddl jobs` (pingcap#36716)
  config, sysvar: add config `instance.enable_ddl` and sysvar `tidb_enable_ddl` (pingcap#35425)
  *: enable part revive for all code (pingcap#36703)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@zimulala zimulala zimulala approved these changes

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

@crazycs520 crazycs520 Awaiting requested review from crazycs520

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add index row count doesn't match the actual row count
6 participants
@Defined2014 @ti-chi-bot @sre-bot @zimulala @tangenta @hawkingrei