Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: fix auto commit variable change effect on transaction commit (#36631) #36755

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Aug 1, 2022

cherry-pick #36631 to release-6.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/36755

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/36755:release-6.1-1cd8c31b1ace

What problem does this PR solve?

Issue Number: close #36581

Problem Summary:

What is changed and how it works?

When changing the value of the session variable auto-commit, the implicit commit for ongoing transactions should happen only when it's changed from off to on.

Check List

Tests

  • Unit test

Side effects

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the auto-commit mode change related transaction commit behaviours.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot requested a review from a team as a code owner August 1, 2022 01:44
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 1, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • you06
  • zyguan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 1, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 1, 2022
@ti-srebot ti-srebot added sig/transaction SIG:Transaction size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/6.1-cherry-pick type/bugfix This PR fixes a bug. labels Aug 1, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 1, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 19, 2022
@cfzjywxk cfzjywxk requested a review from zyguan August 19, 2022 09:36
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 19, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 19, 2022

Copy link
Contributor

@zyguan zyguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 19, 2022
@cfzjywxk
Copy link
Contributor

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Jun 30, 2023
@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 30, 2023

@cfzjywxk: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 30, 2023
@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 30, 2023

@cfzjywxk: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, you06, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cfzjywxk,you06,zyguan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 30, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-30 05:01:20.367122478 +0000 UTC m=+61763.741700330: ☑️ agreed by cfzjywxk.
  • 2023-06-30 05:50:14.409660325 +0000 UTC m=+64697.784238176: ☑️ agreed by zyguan.

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jun 30, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jun 30, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jun 30, 2023
@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 30, 2023

@cfzjywxk: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jun 30, 2023
@cfzjywxk
Copy link
Contributor

Why couldn't it be merged..

@Ivy-YinSu
Copy link

/retest

@tiprow
Copy link

tiprow bot commented Jun 30, 2023

@Ivy-YinSu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ivy-YinSu
Copy link

/test mysql-test

@tiprow
Copy link

tiprow bot commented Jul 3, 2023

@Ivy-YinSu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 3, 2023
@ti-chi-bot ti-chi-bot bot merged commit 2dd186b into pingcap:release-6.1 Jul 3, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jul 12, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/transaction SIG:Transaction size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/6.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants