Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: check virtual column for tiflash (#36771) #36785

Merged
merged 2 commits into from
Aug 2, 2022
Merged

planner: check virtual column for tiflash (#36771) #36785

merged 2 commits into from
Aug 2, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Aug 1, 2022 •
edited
Loading

cherry-pick #36771 to release-6.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/36785

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/36785:release-6.1-dd2e07658aec

Signed-off-by: xufei xufeixw@mail.ustc.edu.cn

What problem does this PR solve?

Issue Number: close #36773, close pingcap/tiflash#5513

Problem Summary:

What is changed and how it works?

TiFlash does not support virtual column, so if the table scan contains virtual column, it can not read from TiFlash

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@windtalker @ti-srebot
cherry pick pingcap#36771 to release-6.1
97a2888 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 1, 2022
@ti-srebot ti-srebot mentioned this pull request Aug 1, 2022
Merged
12 tasks
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/6.1-cherry-pick type/bugfix This PR fixes a bug. labels Aug 1, 2022
@ti-srebot
Copy link
Contributor Author

@windtalker you're already a collaborator in bot's repo.

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 2, 2022
windtalker
windtalker approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 2, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 2, 2022
@windtalker
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1797349

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 2, 2022
@windtalker
Copy link
Contributor

/run-mysql-test

@windtalker
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Aug 2, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/1797349d4db4c6d8c7fab8b917bfb5d85c6a4010

@windtalker
Copy link
Contributor

/run-mysql-test

3 similar comments
@windtalker
Copy link
Contributor

/run-mysql-test

@purelind
Copy link
Contributor

purelind commented Aug 2, 2022

/run-mysql-test

@purelind
Copy link
Contributor

purelind commented Aug 2, 2022

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit c5987a8 into pingcap:release-6.1 Aug 2, 2022
@purelind purelind added this to the v6.1.1 milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@LittleFall LittleFall Awaiting requested review from LittleFall

@zanmato1984 zanmato1984 Awaiting requested review from zanmato1984

Assignees

@windtalker windtalker

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/6.1-cherry-pick
Projects
None yet
Milestone
v6.1.1
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @ti-chi-bot @windtalker @sre-bot @purelind @XuHuaiyu @VelocityLight