-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: check virtual column for tiflash (#36771) #36786
planner: check virtual column for tiflash (#36771) #36786
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@windtalker you're already a collaborator in bot's repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/cbb0dce987c5f46a8326ed5bd5bf4c579d7dd555 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: cbb0dce
|
cherry-pick #36771 to release-6.2
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/36786
After apply modifications, you can push your change to this PR via:
Signed-off-by: xufei xufeixw@mail.ustc.edu.cn
What problem does this PR solve?
Issue Number: close #36773, close pingcap/tiflash#5513
Problem Summary:
What is changed and how it works?
TiFlash does not support virtual column, so if the table scan contains virtual column, it can not read from TiFlash
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.