-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: fix multiple domain creation racing in domap (#36792) #36810
session: fix multiple domain creation racing in domap (#36792) #36810
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@xhebox you're already a collaborator in bot's repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mistake
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/dd3d00aba2a98e108ab7791e5a0ab3d5a2d33fd4 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 0ba4274
|
cherry-pick #36792 to release-6.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/36810
After apply modifications, you can push your change to this PR via:
Signed-off-by: xhe xw897002528@gmail.com
What problem does this PR solve?
Issue Number: close #36791
Problem Summary: As title, refer the issue. After investigation, rwmutex did not bring notable performance gain. Also no one will ever pass a nil store, verified by running all tests, so
if len(dm.domains) == 1 && store == nil {
removed.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.