-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
charset: Support parsing CHARSET=utf8mb3 #37084
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Welcome @k0kubun! |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
/run-check_title |
/cc @WizardXiao |
I don't find the test code in this repository, and the test output is too cryptic to figure out what's happening.
If you can fix the remaining test failures, that'd be appreciated. |
@bb7133 @wjhuang2016 PTAL (with some guide) |
I suggest we can add |
Agreed with your suggestion. I cannot fix this patch immediately, so I'll close my pull request. Thank you! |
Where is the fix mr for map utf8mb3 to utf8 please? Did you merge it? I didn't find your MR, but I'm asking because we're currently having this problem too. |
I wasn't able to fix it. Please feel free to take over my patch in this branch. |
What problem does this PR solve?
Issue Number: close #26226 close #31790
Problem Summary: Support parsing CHARSET=utf8mb3
What is changed and how it works?
utf8mb3 charset support is added.
If you specify
CHARSET=utf8
in MySQL 8, it's translated toCHARSET=utf8mb3
when you useSHOW CREATE TABLE
for example. Here's the definition I used to write this patch:Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.