-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log-backup: restore meta kv with batch method (#37100) #37139
log-backup: restore meta kv with batch method (#37100) #37139
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@joccau you're already a collaborator in bot's repo. |
Signed-off-by: joccau <zak.zhao@pingcap.com>
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9c9ad9aa5eb866fd567f39315682dd9978cecb1e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 9c9ad9a
|
cherry-pick #37100 to release-6.2
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/37139
After apply modifications, you can push your change to this PR via:
Signed-off-by: joccau zak.zhao@pingcap.com
What problem does this PR solve?
Issue Number: close #37111
Problem Summary:
What is changed and how it works?
Set a lots of batch kv files and sort and restore these kv entries in batch files.
Check List
Tests
Manual test
MySQL [(none)]> show create table test.sbtest43; | sbtest43 | CREATE TABLE
sbtest43(
idint(11) NOT NULL AUTO_INCREMENT,
kint(11) NOT NULL DEFAULT '0',
cchar(120) NOT NULL DEFAULT '',
padchar(60) NOT NULL DEFAULT '', PRIMARY KEY (
id) /*T![clustered_index] CLUSTERED */ ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin AUTO_INCREMENT=1019915 |
MySQL [(none)]> show create table test.sbtest43; | sbtest43 | CREATE TABLE
sbtest43(
idint(11) NOT NULL AUTO_INCREMENT,
kint(11) NOT NULL DEFAULT '0',
cchar(120) NOT NULL DEFAULT '',
padchar(60) NOT NULL DEFAULT '', PRIMARY KEY (
id) /*T![clustered_index] CLUSTERED */, KEY
k_43(
k) ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin AUTO_INCREMENT=1019915 |
The Key
K-43
(``) has been restored in above test.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.