-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: Manual revert of #24282 (#35298) #37268
planner: Manual revert of #24282 (#35298) #37268
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@mjonss you're already a collaborator in bot's repo. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/e6afc73acd3bb8566cebc460826b819a84873bcc |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: d5eb9ba
|
/merge |
cherry-pick #35298 to release-6.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/37268
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #35181, closes #33966, ref #22079
Problem Summary:
In PR #24282 there was an optimization added to remove conditions that was used when calculating the pruned partitions, but it has issues with index-out-of-range and having other side-effects, like index usage is no-longer possible. The optimization is also very limited, since it only removes one selection/comparison (if it would be fixed to work as expected) and could only be used if the partition range is consisting of a single value. So it is better to remove the optimization.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.