Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: set EnableOuterJoinReorder to false by default (#37264) #37280

Merged
merged 3 commits into from
Aug 23, 2022
Merged

planner: set EnableOuterJoinReorder to false by default (#37264) #37280

merged 3 commits into from
Aug 23, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Aug 22, 2022 •
edited
Loading

cherry-pick #37264 to release-6.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/37280

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/37280:release-6.1-21847fe58b51

What problem does this PR solve?

Issue Number: ref #37238

Problem Summary:

What is changed and how it works?

Set it to false by default.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@winoros @ti-srebot
cherry pick pingcap#37264 to release-6.1
540604c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot requested a review from a team as a code owner August 22, 2022 11:31
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • chrysan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 22, 2022
@ti-srebot ti-srebot mentioned this pull request Aug 22, 2022
Merged
12 tasks
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/6.1-cherry-pick labels Aug 22, 2022
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 22, 2022
@ti-srebot
Copy link
Contributor Author

@winoros you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 22, 2022
fixdb
fixdb approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ti-chi-bot
Copy link
Member

@fixdb: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

+1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 23, 2022
fixdb
fixdb reviewed Aug 23, 2022
View reviewed changes
sessionctx/variable/sysvar_test.go Outdated
}
}

>>>>>>> 21847fe58... planner: set EnableOuterJoinReorder to false by default (#37264)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@winoros please fix this

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 23, 2022
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 23, 2022
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 23, 2022
@time-and-fate
Copy link
Member

/run-mysql-test tidb-test=pr/1936

@time-and-fate
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b1a0dce

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 23, 2022
@time-and-fate
Copy link
Member

/run-mysql-test tidb-test=pr/1936

2 similar comments
@winoros
Copy link
Member

winoros commented Aug 23, 2022

/run-mysql-test tidb-test=pr/1936

@time-and-fate
Copy link
Member

/run-mysql-test tidb-test=pr/1936

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 23, 2022
@winoros
Copy link
Member

winoros commented Aug 23, 2022

/run-mysql-test tidb-test=pr/1936

@winoros
Copy link
Member

winoros commented Aug 23, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 37b6894

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 23, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 23, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/37b689458691ea6c2c5d9315f88b0e7e18e8b6f2

@winoros
Copy link
Member

winoros commented Aug 23, 2022

/run-mysql-test tidb-test=pr/1936

@ti-chi-bot ti-chi-bot merged commit 3000d06 into pingcap:release-6.1 Aug 23, 2022
@purelind purelind added this to the v6.1.1 milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fixdb fixdb fixdb approved these changes

@AilinKid AilinKid AilinKid approved these changes

@chrysan chrysan chrysan approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees

@winoros winoros

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/6.1-cherry-pick
Projects
None yet
Milestone
v6.1.1
Development

Successfully merging this pull request may close these issues.
10 participants
@ti-srebot @ti-chi-bot @time-and-fate @winoros @sre-bot @fixdb @chrysan @AilinKid @VelocityLight @purelind