Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor, util: fix UnionScan Next() skip reading data when passed chunk capacity is 0 (#36961) #37333

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Aug 24, 2022

cherry-pick #36961 to release-6.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/37333

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/37333:release-6.0-81a93a6977e5

What problem does this PR solve?

Issue Number: close #36903

Problem Summary:

What is changed and how it works?

In the old UnionScan executor code, if an empty chk is passed to UnionScan.Next(chk) , the UnionScan executor will not read any data.

This bug could be trigger in select pkey from t_vwvgdc where 0 <> 0 union select pkey from t_vwvgdc;
The union first children return empty chunk, and the chunk is reused for the second children (union scan) to read data.

mysql> explain select pkey from t_vwvgdc where 0 <> 0 union select pkey from t_vwvgdc;
+------------------------------+---------+-----------+----------------+-------------------------------------------------------+
| id                           | estRows | task      | access object  | operator info                                         |
+------------------------------+---------+-----------+----------------+-------------------------------------------------------+
| HashAgg_13                   | 24.20   | root      |                | group by:Column#7, funcs:firstrow(Column#7)->Column#7 |
| └─Union_14                   | 29.00   | root      |                |                                                       |
|   ├─TableDual_16             | 0.00    | root      |                | rows:0                                                |
|   └─UnionScan_18             | 29.00   | root      |                |                                                       |
|     └─TableReader_20         | 29.00   | root      |                | data:TableFullScan_19                                 |
|       └─TableFullScan_19     | 29.00   | cop[tikv] | table:t_vwvgdc | keep order:false, stats:pseudo                        |
+------------------------------+---------+-----------+----------------+-------------------------------------------------------+
6 rows in set (0.00 sec)

Now I change req.GrowAndReset(us.maxChunkSize) to ensure capacity > 0 for the req.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix a bug that UnionScan's Next() function skips reading data when the passed chunk's capacity is 0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 24, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 24, 2022
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 24, 2022
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/6.0-cherry-pick labels Aug 24, 2022
@ti-srebot
Copy link
Contributor Author

@tiancaiamao you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 24, 2022
@tiancaiamao
Copy link
Contributor

6.0 is not LTS version, no need to cherry-pick

@tiancaiamao tiancaiamao deleted the release-6.0-81a93a6977e5 branch August 25, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. type/6.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants