Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: mark the both side operand of NAAJ & refuse partial column substitute in projection elimination of Apply de-correlation (#37117) #37352

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Aug 24, 2022

cherry-pick #37117 to release-6.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/37352

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/37352:release-6.0-d3483026ede6

Signed-off-by: AilinKid 314806019@qq.com

What problem does this PR solve?

Issue Number: close #37032

Problem Summary:
two problems mainly:
1: in the projection elimination of Apply decorrelate rule, we try to substitute any condition used in Apply with raw projected expression under this projection, after which this projection can be eliminated. But we should make sure
that all columns mapped from the schema of projection OP must be substituted atomically (all succeed or fail).

2: Consider an EQ condition converted from NOT IN OP (NAAJ), in which we used to mark the right side column of this "NA" EQ as InOperand=true. In some cases like columns substitution as we talked about above, cases like:

(a NA EQ b (marked InOperand=true ) ) where b will be substituted with like a constant string, so we got (a NA EQ "example" ), this condition will not be considered as a NA EQ condition anymore and will be moved from other condition to equal condition of join OP in the logical rule of pddResolver .

What is changed and how it works?

1: NAAJ is not just about one side, mark both as inOperand=true. so even the right has successfully been substituted with a constant string, we can also get (a (marked InOperand=true) NA EQ "example" ) as a NA EQ in the other condition.

2: make the column substitution atomically (all succeed or fail) in projection elimination of Apply decorrelation.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

make the both side operand of NAAJ & refuse partial column substitute in projection elimination

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 24, 2022
@ti-chi-bot ti-chi-bot removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 24, 2022
@ti-srebot ti-srebot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/6.0-cherry-pick labels Aug 24, 2022
@ti-srebot
Copy link
Contributor Author

@AilinKid you're already a collaborator in bot's repo.

@sre-bot
Copy link
Contributor

sre-bot commented Aug 24, 2022

@xhebox
Copy link
Contributor

xhebox commented Aug 30, 2022

closed for DMR version

@xhebox xhebox closed this Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/6.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants