-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types: fix a bug in casting str2str when union
(#37242)
#37363
types: fix a bug in casting str2str when union
(#37242)
#37363
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
/run-check_dev_2 |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/a645170c677da9361681aeb084fb894846ea8fff |
/reopen |
@CbcWestwolf: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 532a73a
|
cherry-pick #37242 to release-6.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/37363
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #31678
Problem Summary:
When building the plan of union, the
flen
of the projection targetFieldType
is mis-computed.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.