Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: decoupling of backfill worker and reorg worker codes, add backfill workerPool #37538

Merged
merged 11 commits into from
Sep 6, 2022
Merged

ddl: decoupling of backfill worker and reorg worker codes, add backfill workerPool #37538

merged 11 commits into from
Sep 6, 2022

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Sep 1, 2022

What problem does this PR solve?

Issue Number: close #37124

Problem Summary:

What is changed and how it works?

  • update some function arguments to make backfillWorker doesn't depend on ddlWorker.
  • update functions position
  • add backfilWorkerPool and tests
  • rename function names

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 1, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2022
@zimulala zimulala added the type/feature-request Categorizes issue or PR as related to a new feature. label Sep 1, 2022
@zimulala
Copy link
Contributor Author

zimulala commented Sep 1, 2022

/run-check-issue-triage-complete

@zimulala zimulala changed the title Decoupling of Backfill worker and Reorg worker codes, add backfill workerPool ddl: decoupling of Backfill worker and Reorg worker codes, add backfill workerPool Sep 1, 2022
@zimulala zimulala changed the title ddl: decoupling of Backfill worker and Reorg worker codes, add backfill workerPool ddl: decoupling of backfill worker and reorg worker codes, add backfill workerPool Sep 1, 2022
@hawkingrei hawkingrei self-requested a review September 1, 2022 07:02
@zimulala zimulala requested review from Benjamin2037, Defined2014, hawkingrei and tangenta and removed request for hawkingrei September 1, 2022 07:02
tangenta
tangenta reviewed Sep 1, 2022
View reviewed changes
ddl/backfilling.go Outdated
// there are taskCnt running workers.
func (w *worker) handleReorgTasks(reorgInfo *reorgInfo, totalAddedCount *int64, workers []*backfillWorker, batchTasks []*reorgBackfillTask) error {
func (dc *ddlCtx) deliveryTasksAndResults(sessPool *sessionPool, reorgInfo *reorgInfo, totalAddedCount *int64, workers []*backfillWorker, batchTasks []*reorgBackfillTask) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about naming it with sendTasksAndWait?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

tangenta
tangenta approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 1, 2022
Defined2014
Defined2014 reviewed Sep 5, 2022
View reviewed changes
ddl/backfilling.go Outdated Show resolved Hide resolved
@zimulala
Copy link
Contributor Author

zimulala commented Sep 6, 2022

PTAL @Defined2014

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 6, 2022
@hawkingrei
Copy link
Member

@zimulala Please fix the linter.

@zimulala
Copy link
Contributor Author

zimulala commented Sep 6, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1b689dc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 6, 2022
@zimulala zimulala merged commit 737cd0e into pingcap:master Sep 6, 2022
@zimulala zimulala deleted the zimuxia/add-backfill-pool branch September 6, 2022 06:23
@sre-bot
Copy link
Contributor

sre-bot commented Sep 6, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 15 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 8 min 52 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 53 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 4 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 34 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 11 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 1 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 left review comments

@tangenta tangenta tangenta approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@Benjamin2037 Benjamin2037 Awaiting requested review from Benjamin2037

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decoupling of Backfill worker and Reorg worker codes, add backfill workerPool
6 participants
@zimulala @ti-chi-bot @hawkingrei @sre-bot @Defined2014 @tangenta