Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session, planner: add a session variable "tidb_opt_force_inline_cte" #37626

Merged
merged 9 commits into from
Sep 8, 2022
Merged

session, planner: add a session variable "tidb_opt_force_inline_cte" #37626

merged 9 commits into from
Sep 8, 2022

Conversation

elsa0520
Copy link
Contributor

@elsa0520 elsa0520 commented Sep 5, 2022

What problem does this PR solve?

This pr adds a new session variable,
which is mainly used to control whether all CTEs in the entire session are inlined or not.
The default value is false, which means that inline cte is not enabled by default.
(But if the user directly specifies the merge hint, it can still be turned on)
If the variable is set to true, it means that all CTEs for this session try to enable inlining.

Issue Number: close #36514

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@elsa0520 elsa0520 requested a review from a team as a code owner September 5, 2022 10:13
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 5, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • fixdb

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 5, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Sep 5, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot
Copy link
Member

Welcome @elsa0520!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 5, 2022
@elsa0520
Copy link
Contributor Author

elsa0520 commented Sep 5, 2022

@fixdb PTAL

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 5, 2022
@Reminiscent
Copy link
Contributor

@elsa0520 The test check_dev is failed. You can click the details for more details.

[2022-09-05T10:14:38.007Z]   ✘  https://revive.run/r#exported  exported method SessionVars.EnableInlineCTE should have comment or be unexported  
[2022-09-05T10:14:38.007Z]   sessionctx/variable/session.go:2994:1

Rest LGTM.

@elsa0520
Copy link
Contributor Author

elsa0520 commented Sep 6, 2022

@elsa0520 The test check_dev is failed. You can click the details for more details.

[2022-09-05T10:14:38.007Z]   ✘  https://revive.run/r#exported  exported method SessionVars.EnableInlineCTE should have comment or be unexported  
[2022-09-05T10:14:38.007Z]   sessionctx/variable/session.go:2994:1

Rest LGTM.

Fixed check-dev
The problem with mysql-test does not seem to be caused by this PR, other PRs have the same problem.

@elsa0520
planner: add a session variable "tidb_opt_inline_cte"
9bfa8f2 
This pr adds a new session variable,
which is mainly used to control whether all CTEs in the entire session are inlined or not.
The default value is false, which means that inline cte is not enabled by default.
(But if the user directly specifies the merge hint, it can still be turned on)
If the variable is set to true, it means that all CTEs for this session try to enable inlining.

Fixed pingcap#36514
@elsa0520
add comment
68de505
fixdb
fixdb reviewed Sep 7, 2022
View reviewed changes
planner/core/testdata/plan_suite_in.json Outdated Show resolved Hide resolved
planner/core/testdata/plan_suite_in.json Outdated Show resolved Hide resolved
planner/core/logical_plan_builder.go Show resolved Hide resolved
@elsa0520 elsa0520 changed the title session, planner: add a session variable "tidb_opt_inline_cte" session, planner: add a session variable "tidb_opt_force_inline_cte" Sep 7, 2022
fixdb
fixdb reviewed Sep 7, 2022
View reviewed changes
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add test cases where

  1. non-recursive CTE definition inside another non-recursive CTE
  2. defining non-recursive CTE inside recursive CTE
  3. defining recursive inside non-recursive CTE

@ti-chi-bot ti-chi-bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 8, 2022
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 8, 2022
@elsa0520
Copy link
Contributor Author

elsa0520 commented Sep 8, 2022

Can we add test cases where

  1. non-recursive CTE definition inside another non-recursive CTE
  2. defining non-recursive CTE inside recursive CTE
  3. defining recursive inside non-recursive CTE

Done

fixdb
fixdb approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 8, 2022
@qw4990
Copy link
Contributor

qw4990 commented Sep 8, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 418e3c1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 8, 2022
@ti-chi-bot ti-chi-bot merged commit ca5de89 into pingcap:master Sep 8, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Sep 8, 2022

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 14 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 26 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 14 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 41 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 35 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 12 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 24 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 17 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 58 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent approved these changes

@qw4990 qw4990 qw4990 approved these changes

@fixdb fixdb fixdb approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a system variable to control whether to inline CTE or not
6 participants
@elsa0520 @ti-chi-bot @sre-bot @Reminiscent @qw4990 @fixdb