-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: add cache padding for lock of RowContainer #37627
Conversation
Signed-off-by: gengliqi <gengliqiii@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-build-arm64 comment=true |
download tidb binary(linux arm64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tidb/506f1b659c20478053df43eab537df60472553e4/centos7/tidb-linux-arm64.tar.gz |
Signed-off-by: gengliqi <gengliqiii@gmail.com>
Signed-off-by: gengliqi <gengliqiii@gmail.com>
/run-build-arm64 comment=true |
download tidb binary(linux arm64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tidb/1f1f0e1c853f10a1c07b9c4463fea8b5fe9b8f62/centos7/tidb-linux-arm64.tar.gz |
Signed-off-by: gengliqi <gengliqiii@gmail.com>
/run-build-arm64 comment=true |
download tidb binary(linux arm64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tidb/3d3acbe57d538f2aa4668b22ad0f3b5f016e034c/centos7/tidb-linux-arm64.tar.gz |
This reverts commit 3d3acbe. Signed-off-by: gengliqi <gengliqiii@gmail.com>
/run-build comment=true |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e003638
|
TiDB MergeCI notify🔴 Bad News! [2] CI still failing after this pr merged.
|
Signed-off-by: gengliqi gengliqiii@gmail.com
What problem does this PR solve?
Issue Number: close #37641
Problem Summary:
As #37641 said, there are false sharing issue and true sharing issue of lock of RowContainer.
For the false sharing issue, this PR adds a cache padding for lock of RowContainer.
For the true sharing issue, this PR makes different workers use the different
rlock
.Although the issue said we should find a more elegant method to solve this issue, @Yui-Song told me that the result of a certain test has a very unstable time which causes some warning reports. So it's better to solve this issue immediately.
We'll leave the reconstruction work to finish later.
Performance test by the complex query mentioned in #37641.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.