-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: move TestCheckRequirementsTiFlash
out of local
package
#37716
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
TestCheckRequirementsTiFlash
out of 'local' packageTestCheckRequirementsTiFlash
out of local
package
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 43c9604
|
TiDB MergeCI notify🔴 Bad News! [3] CI still failing after this pr merged.
|
What problem does this PR solve?
Issue Number: ref #35983
Problem Summary:
The test
TestCheckRequirementsTiFlash
creates an indirect dependency fromlocal
package toddl
package. The add index acceleration solution requires the reverted dependency.What is changed and how it works?
Move this test to the
local_test
package.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.