Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time: fix the fraction loss when encountering time string with timezone suffix (#37820) #37994

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Sep 20, 2022

cherry-pick #37820 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/37994

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/37994:release-5.3-b8d929c3c754

What problem does this PR solve?

Issue Number: close #35291

Problem Summary:

What is changed and how it works?

Identify the position of the timezone before identifying the position of the fraction in the time string to avoid the accuracy loss. Timezone will also be checked later to ensure compatibility so that there is duplicate detection for timezone.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
DROP TABLE IF EXISTS `testSetObjectTime`;
CREATE TABLE `testSetObjectTime` (
  `id` int(11) DEFAULT NULL,
  `d` time(6) DEFAULT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin;
INSERT INTO testSetObjectTime VALUES (1, '2020-01-01 12:00:00.123456000+05:00');
INSERT INTO testSetObjectTime VALUES (2, '2020-01-01 12:00:00.123456+05:00');
SELECT * FROM testSetObjectTime;
+------+-----------------+
| id   | d               |
+------+-----------------+
|    1 | 15:00:00.123456 |
|    2 | 15:00:00.123456 |
+------+-----------------+

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 20, 2022
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

@Qiaolin-Yu you're already a collaborator in bot's repo.

@windtalker windtalker closed this Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.3-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants