-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix a bug that 'flashback table' does not handle mysql.gc_delete_range correctly #38038
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 554507f
|
After discuss with @crazycs520 , it's not him who misunderstand the Later, #33726 try to fix another bug, and change the |
/merge |
/run-unit-test |
1 similar comment
/run-unit-test |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-6.1 in PR #38050 |
/run-cherry-picker |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-6.3 in PR #38052 |
TiDB MergeCI notify🔴 Bad News! [3] CI still failing after this pr merged.
|
What problem does this PR solve?
Issue Number: close #37386
Problem Summary:
What is changed and how it works?
@crazycs520 regard the
element_id
ofmysql.gc_delete_range
as table ID mistakenly...So the constructed SQL from deleting the
gc_delete_range
record is wrong.element_id
is not table id, it's just an ID to distinguish multiple records within a job.Check List
Tests
unistore doesn't implement the
flashback table
utilities, so I can't write the unit test.I verified that #37386 is solved after this change.
And also,
Check the gc_delete_range is correct in each step.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.