-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
execution: commit the transaction before responding explain analyze results to the client (#38044) #38057
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@cfzjywxk please accept the invitation then you can push to the cherry-pick pull requests. Comment with |
This pull request is closed because it's related version has closed automatic cherry-picking. You can find more details at: |
cherry-pick #38044 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/38057
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #37373
Problem Summary:
The explain analyze statement execution with DML executors may respond to the client before the transaction commit finishing.
What is changed and how it works?
Trigger the commit operation if the statement is an
explain analyze
statement with DML executors before returning the record set of itself.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.