Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expression: implement NullEq function pushdown. #38099

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Expression: implement NullEq function pushdown. #38099

wants to merge 4 commits into from
+50 −1

Conversation

JigaoLuo
Copy link

Signed-off-by: Jigao Luo luojigao@outlook.com

What problem does this PR solve?

Issue Number: close #38098
Related Issue: pingcap/tiflash#5102

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support to pushdown NullEq to TiFlash

@JigaoLuo
Expression: implement NullEq function pushdown.
92255b2 
Signed-off-by: Jigao Luo <luojigao@outlook.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 22, 2022
@ti-chi-bot
Copy link
Member

Welcome @cakebytheoceanLuo!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

@JigaoLuo
Copy link
Author

/cc @zanmato1984

@JigaoLuo
Copy link
Author

/cc @SeaRise

@sre-bot
Copy link
Contributor

sre-bot commented Sep 23, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@JigaoLuo
Add more integration tests.
b66a4ad 
Signed-off-by: Jigao Luo <luojigao@outlook.com>
@JigaoLuo JigaoLuo force-pushed the feature-NullEq-function-push-down branch from bb5099d to b66a4ad Compare September 24, 2022 12:41
SeaRise
SeaRise reviewed Sep 26, 2022
View reviewed changes
expression/expr_to_pb_test.go
@@ -1153,6 +1153,11 @@ func TestExprPushDownToFlash(t *testing.T) {
require.NoError(t, err)
exprs = append(exprs, function)

// ScalarFuncSig_NullEQ
function, err = NewFunction(mock.NewContext(), ast.NullEQ, types.NewFieldType(mysql.TypeLonglong), intColumn, intColumn)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and add test cases for more data types?

planner/core/integration_test.go

tk.MustExec("use test")
tk.MustExec("drop table if exists t")
tk.MustExec("create table t(a int, b varchar(20))")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@SeaRise
Copy link
Contributor

SeaRise commented Sep 26, 2022

please add the tiflash pr link.

@JigaoLuo
Copy link
Author

please add the tiflash pr link.

Thanks for the review. The tiflash side is still on working.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2022
@ti-chi-bot
Copy link
Member

@JigaoLuo: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeaRise SeaRise SeaRise left review comments

@zanmato1984 zanmato1984 Awaiting requested review from zanmato1984

Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement NullEq function pushdown
6 participants
@JigaoLuo @ti-chi-bot @sre-bot @SeaRise @zanmato1984 @hawkingrei