Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: support tracing adding index #38110

Closed
wants to merge 26 commits into from
Closed

ddl: support tracing adding index #38110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
8cb6346
ddl: support tracing adding index
tangenta Sep 22, 2022
a8e171b
trace lightning import phase
tangenta Sep 22, 2022
b61eacb
update bazel
tangenta Sep 22, 2022
6288984
update bazel
tangenta Sep 22, 2022
8d5ec90
update minitrace
tangenta Sep 23, 2022
2ccca06
delete unused trace
tangenta Sep 23, 2022
5f91519
print seconds instead
tangenta Sep 28, 2022
b66b142
add more details tracing
tangenta Sep 28, 2022
ea2908d
group event by worker ID
tangenta Sep 29, 2022
bb950ff
use copr to fetch row values
tangenta Oct 10, 2022
f2ee374
support push down index record encoding
tangenta Oct 11, 2022
1ac68e4
support async read and write
tangenta Oct 12, 2022
68f5659
change the read write ratio to 2 : 1
tangenta Oct 13, 2022
18b6d21
pipeline copr reader and writer
tangenta Oct 13, 2022
ca070d0
revert small changes
tangenta Oct 13, 2022
0c3c0b1
send next cop request without blocking
tangenta Oct 14, 2022
093a620
add tracing for cop-read and fetch-chan-rows
tangenta Oct 14, 2022
03ec3af
writers can receive index records from all the ranges
tangenta Oct 14, 2022
dd35bfa
refactor send reorg task code
tangenta Oct 18, 2022
111fd5c
use a separate kv structure for copr push down impl
tangenta Oct 18, 2022
720dd54
record time detail at a fine-grained level
tangenta Oct 18, 2022
929605c
push down sort
tangenta Oct 19, 2022
2a2fad1
Revert "push down sort"
tangenta Oct 20, 2022
bdeaec2
remove unnecessary time record
tangenta Oct 20, 2022
bfe69ca
reduce unnecessary memory allocation
tangenta Oct 20, 2022
ebf2617
trace sendIdxRecords
tangenta Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 40 additions & 2 deletions DEPS.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2645,8 +2645,8 @@ def go_deps():
name = "com_github_opentracing_basictracer_go",
build_file_proto_mode = "disable_global",
importpath = "github.com/opentracing/basictracer-go",
sum = "h1:YyUAhaEfjoWXclZVJ9sGoNct7j4TVk7lZWlQw5UXuoo=",
version = "v1.0.0",
sum = "h1:Oa1fTSBvAl8pa3U+IJYqrKm0NALwH9OsgwOqDv4xJW0=",
version = "v1.1.0",
)
go_repository(
name = "com_github_opentracing_contrib_go_stdlib",
Expand Down Expand Up @@ -2750,6 +2750,14 @@ def go_deps():
sum = "h1:JhzVVoYvbOACxoUmOs6V/G4D5nPVUW73rKvXxP4XUJc=",
version = "v0.0.0-20180830031419-95f893ade6f2",
)
go_repository(
name = "com_github_philhofer_fwd",
build_file_proto_mode = "disable",
importpath = "github.com/philhofer/fwd",
sum = "h1:GdGcTjf5RNAxwS4QLsiMzJYj5KEvPJD3Abr261yRQXQ=",
version = "v1.1.1",
)

go_repository(
name = "com_github_pierrec_lz4",
build_file_proto_mode = "disable_global",
Expand Down Expand Up @@ -3193,6 +3201,14 @@ def go_deps():
sum = "h1:y0cMJ0qjii33BnD6tMGcF/+gHYsoKQ6tbwQpy233OII=",
version = "v0.0.0-20180711163814-62bca832be04",
)
go_repository(
name = "com_github_silentred_gid",
build_file_proto_mode = "disable",
importpath = "github.com/silentred/gid",
sum = "h1:JdsH8McqPUeY8IN4C0gxENnJG2zysvh+/xDJWhPvGVQ=",
version = "v1.0.0",
)

go_repository(
name = "com_github_sirupsen_logrus",
build_file_proto_mode = "disable_global",
Expand Down Expand Up @@ -3410,6 +3426,14 @@ def go_deps():
sum = "h1:p8XInTnkUlLabBT7bDS3aZCeemO6tJ/7b5mHN8WbSIE=",
version = "v2.0.1-0.20220913051514-ffaaf7131a8d",
)
go_repository(
name = "com_github_tikv_minitrace_go",
build_file_proto_mode = "disable",
importpath = "github.com/tikv/minitrace-go",
sum = "h1:nvIrUVo5YJZMsCn6yTxrpgrokIo/wug5N/nL5mc7v50=",
version = "v0.0.0-20220923091513-8e6316bb4097",
)

go_repository(
name = "com_github_tikv_pd_client",
build_file_proto_mode = "disable_global",
Expand All @@ -3431,6 +3455,13 @@ def go_deps():
sum = "h1:phZCcypL/vtx6cGxObJgWZ5wexZF5SXFPLOM+ru0e/M=",
version = "v0.1.0",
)
go_repository(
name = "com_github_tinylib_msgp",
build_file_proto_mode = "disable",
importpath = "github.com/tinylib/msgp",
sum = "h1:2gXmtWueD2HefZHQe1QOy9HVzmFrLOVvsXwXBQ0ayy0=",
version = "v1.1.5",
)

go_repository(
name = "com_github_tklauser_go_sysconf",
Expand Down Expand Up @@ -3467,6 +3498,13 @@ def go_deps():
sum = "h1:iAj0a8e6+dXSL7Liq0aXPox36FiN1dBbjA6lt9fl65s=",
version = "v2.5.0",
)
go_repository(
name = "com_github_ttacon_chalk",
build_file_proto_mode = "disable",
importpath = "github.com/ttacon/chalk",
sum = "h1:OXcKh35JaYsGMRzpvFkLv/MEyPuL49CThT1pZ8aSml4=",
version = "v0.0.0-20160626202418-22c06c80ed31",
)

go_repository(
name = "com_github_twmb_murmur3",
Expand Down
1 change: 1 addition & 0 deletions br/pkg/task/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ go_library(
"//br/pkg/utils",
"//br/pkg/version",
"//config",
"//ddl",
"//kv",
"//parser/model",
"//parser/mysql",
Expand Down
5 changes: 5 additions & 0 deletions ddl/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,14 @@ go_library(
"ddl_api.go",
"ddl_tiflash_api.go",
"ddl_worker.go",
"ddl_worker_util.go",
"ddl_workerpool.go",
"delete_range.go",
"delete_range_util.go",
"foreign_key.go",
"generated_column.go",
"index.go",
"index_distsql.go",
"index_merge_tmp.go",
"job_table.go",
"mock.go",
Expand Down Expand Up @@ -99,6 +101,7 @@ go_library(
"//util/domainutil",
"//util/filter",
"//util/gcutil",
"//util/generic",
"//util/hack",
"//util/logutil",
"//util/mathutil",
Expand Down Expand Up @@ -128,6 +131,8 @@ go_library(
"@com_github_tikv_client_go_v2//tikv",
"@com_github_tikv_client_go_v2//tikvrpc",
"@com_github_tikv_client_go_v2//txnkv/rangetask",
"@com_github_tikv_minitrace_go//:minitrace-go",
"@com_github_tikv_minitrace_go//jaeger",
"@io_etcd_go_etcd_client_v3//:client",
"@org_golang_x_exp//slices",
"@org_uber_go_atomic//:atomic",
Expand Down
Loading