Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: make the meaning of displayed estimated row count consistent with actual row count #38188

Merged
merged 15 commits into from
Oct 17, 2022
Merged

planner: make the meaning of displayed estimated row count consistent with actual row count #38188

merged 15 commits into from
Oct 17, 2022

Conversation

time-and-fate
Copy link
Member

@time-and-fate time-and-fate commented Sep 27, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #38187

Problem Summary:

Please see the issue and the doc PR.

What is changed and how it works?

  1. Add a new field probeParents to all PhysicalPlan implementations (please see the comments for the explanation).
  2. Add three new methods setProbeParents, getEstRowCountForDisplay and getActualProbeCnt to the PhysicalPlan interface. The getEstRowCountForDisplay and getActualProbeCnt will enable us to convert the row count between the "single probe" row count and the "all probes" row count as we need.
  3. Add a new step propagateProbeParents in postOptimize to traverse the plan tree and set the probeParents.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 27, 2022
@time-and-fate time-and-fate changed the title planner: make the meaning of displayed estimated row count consistent of actual row count planner: make the meaning of displayed estimated row count consistent with actual row count Sep 27, 2022
@time-and-fate
Copy link
Member Author

/run-mysql-test tidb-test=pr/1988

1 similar comment
@time-and-fate
Copy link
Member Author

/run-mysql-test tidb-test=pr/1988

@time-and-fate
Copy link
Member Author

/run-mysql-test tidb-test=pr/1988

2 similar comments
@time-and-fate
Copy link
Member Author

/run-mysql-test tidb-test=pr/1988

@time-and-fate
Copy link
Member Author

/run-mysql-test tidb-test=pr/1988

@time-and-fate
Copy link
Member Author

/run-mysql-test tidb-test=pr/1988

5 similar comments
@time-and-fate
Copy link
Member Author

/run-mysql-test tidb-test=pr/1988

@time-and-fate
Copy link
Member Author

/run-mysql-test tidb-test=pr/1988

@time-and-fate
Copy link
Member Author

/run-mysql-test tidb-test=pr/1988

@time-and-fate
Copy link
Member Author

/run-mysql-test tidb-test=pr/1988

@time-and-fate
Copy link
Member Author

/run-mysql-test tidb-test=pr/1988

@wuhuizuo
Copy link
Contributor

/run-check-dev

@qw4990 qw4990 added sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement. labels Sep 28, 2022
@wuhuizuo
Copy link
Contributor

/run-check-dev

1 similar comment
@wuhuizuo
Copy link
Contributor

/run-check-dev

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2022
qw4990
qw4990 reviewed Oct 8, 2022
View reviewed changes
planner/core/optimizer.go
@@ -382,6 +382,7 @@ func postOptimize(sctx sessionctx.Context, plan PhysicalPlan) PhysicalPlan {
plan = enableParallelApply(sctx, plan)
handleFineGrainedShuffle(sctx, plan)
checkPlanCacheable(sctx, plan)
propagateProbeParents(plan, nil)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we invoke this function only when sctx.GetSessionVars().StmtCtx.InExplainStmt == true?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.
Because of features like slow query and statements summary, every execution plan is possible to be recorded and displayed.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 8, 2022
@qw4990
Copy link
Contributor

qw4990 commented Oct 8, 2022

Please resolve conflicts @time-and-fate

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 11, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2022
@time-and-fate
Copy link
Member Author

/run-mysql-test tidb-test=pr/1988

1 similar comment
@time-and-fate
Copy link
Member Author

/run-mysql-test tidb-test=pr/1988

@time-and-fate
Copy link
Member Author

/run-mysql-test tidb-test=pr/1988

@time-and-fate
Copy link
Member Author

/run-mysql-test tidb-test=pr/1988

@time-and-fate
Copy link
Member Author

/run-check_dev_2

This was referenced Oct 13, 2022
Merged
Merged
@time-and-fate
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7e8028c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 17, 2022
@time-and-fate
Copy link
Member Author

/merge

@time-and-fate
Copy link
Member Author

/run-mysql-test tidb-test=pr/1988

@ti-chi-bot ti-chi-bot merged commit 5fa9da1 into pingcap:master Oct 17, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Oct 17, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🟥 failed 1, success 10, total 11 11 min New failing
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 8, success 9, total 17 13 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 28 min Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 27 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 43 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 10 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 10 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 3 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 34 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@pcqz pcqz mentioned this pull request Jun 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keep consistency between the meaning of the estimated and actual row count in the result of EXPLAIN ANALYZE
6 participants
@time-and-fate @ti-chi-bot @wuhuizuo @qw4990 @sre-bot @winoros