-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: outer join elimination doesn't consider the ORDER BY items from the agg func #38380
planner: outer join elimination doesn't consider the ORDER BY items from the agg func #38380
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 0994fa6
|
In response to a cherrypick label: cannot checkout |
/run-cherry-picker release-6.1 |
/cherry-pick release-6.1 |
@winoros: new pull request created: #38385. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
…rom the agg func (pingcap#38380) (pingcap#39024) close pingcap#18216
What problem does this PR solve?
Issue Number: close #18216
Problem Summary:
Outer join is wrongly eliminated since we don't take the ORDER BY items from the GROUP_CONCAT.
What is changed and how it works?
Add it.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.