-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log-backup: using streaming to load metadata for preventing OOM #38386
Conversation
Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
Signed-off-by: Yu Juncen <yu745514916@live.com>
🤔 |
Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 547d879
|
What problem does this PR solve?
Issue Number: close #38404
Problem Summary:
This PR make the restore procedure load the metadata lazily.
What is changed and how it works?
This PR has introduced a new package
iter
, which provides theimpure
iterator typeTryNextor
.Then the restore procedure is someway rewritten, to allow the restoration of data files become pipelined.
For better testing and isolate the code using generics, this PR also extracted the file read part from the
restore.Client
torestore.logFileManager
.Test Result
Check List
Tests
Side effects
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.