Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add a meta column in value indicate whether it should be ignore by ticdc #38500

Closed
wants to merge 16 commits into from
Closed

*: add a meta column in value indicate whether it should be ignore by ticdc #38500

wants to merge 16 commits into from

Conversation

xiongjiwei
Copy link
Contributor

@xiongjiwei xiongjiwei commented Oct 17, 2022 •
edited
Loading

Signed-off-by: xiongjiwei xiongjiwei1996@outlook.com

What problem does this PR solve?

Issue Number: ref #38587

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 18, 2022
@xiongjiwei xiongjiwei force-pushed the smp-data branch 2 times, most recently from 6c5d452 to 655352e Compare October 19, 2022 06:30
@xiongjiwei
Copy link
Contributor Author

/run-build

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2022
@xiongjiwei
Copy link
Contributor Author

/run-mysql-test tidb-test=pr/1997

@xiongjiwei xiongjiwei changed the title *: data *: add a meta column in value indicate wheatear it shoud be ignore by ticdc Oct 21, 2022
@xiongjiwei xiongjiwei marked this pull request as ready for review October 21, 2022 03:10
@xiongjiwei xiongjiwei requested a review from a team as a code owner October 21, 2022 03:10
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2022
@xiongjiwei xiongjiwei marked this pull request as draft October 21, 2022 03:12
@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2022
@xiongjiwei xiongjiwei marked this pull request as ready for review October 21, 2022 04:06
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2022
@xiongjiwei
Copy link
Contributor Author

/run-build

xiongjiwei and others added 6 commits October 26, 2022 15:48
@xiongjiwei
fix test
2da8b47
@xiongjiwei
add test
e1df0ef 
Signed-off-by: xiongjiwei <xiongjiwei1996@outlook.com>
@xiongjiwei
update comment
1fee879 
Signed-off-by: xiongjiwei <xiongjiwei1996@outlook.com>
@xiongjiwei
add partition table test
b0dfec7 
Signed-off-by: xiongjiwei <xiongjiwei1996@outlook.com>
@xiongjiwei
update impl
6c8e69d 
Signed-off-by: xiongjiwei <xiongjiwei1996@outlook.com>
@xiongjiwei @tangenta
Update sessionctx/variable/session.go
9ac18ee 
Co-authored-by: tangenta <tangenta@126.com>
Signed-off-by: xiongjiwei <xiongjiwei1996@outlook.com>
@xiongjiwei
Copy link
Contributor Author

/run-unit-test

@xiongjiwei
Copy link
Contributor Author

/run-build

@xiongjiwei
Copy link
Contributor Author

/run-unit-test

@xiongjiwei
fix test
9c367a5 
Signed-off-by: xiongjiwei <xiongjiwei1996@outlook.com>
@xiongjiwei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9c367a5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 26, 2022
@xiongjiwei
Copy link
Contributor Author

/run-check_dev_2

@xiongjiwei
Copy link
Contributor Author

/run-mysql-test

@xiongjiwei
Copy link
Contributor Author

/run-check_dev_2

@xiongjiwei
Copy link
Contributor Author

/run-mysql-test

@xiongjiwei
Copy link
Contributor Author

/run-unit-test

@xiongjiwei
Copy link
Contributor Author

/run-mysql-test

@xiongjiwei
Copy link
Contributor Author

/run-check_dev_2

1 similar comment
@xiongjiwei
Copy link
Contributor Author

/run-check_dev_2

@ti-chi-bot
Copy link
Member

@xiongjiwei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xiongjiwei
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2022
bb7133
bb7133 reviewed Oct 27, 2022
View reviewed changes
sessionctx/variable/session.go Outdated Show resolved Hide resolved
table/tables/tables.go
@@ -427,6 +427,8 @@ func (t *TableCommon) UpdateRecord(ctx context.Context, sctx sessionctx.Context,
}
}

colIDs, row = appendMetaCol(sctx, colIDs, row)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see appendMetaCol is added to UpdateRecord() and AddRecord(), how about RemoveRecord?

@xiongjiwei @bb7133
Update sessionctx/variable/session.go
f149d66 
Co-authored-by: bb7133 <bb7133@gmail.com>
@xiongjiwei xiongjiwei closed this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@tangenta tangenta tangenta approved these changes

@xhebox xhebox xhebox approved these changes

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xiongjiwei @ti-chi-bot @bb7133 @xhebox @tangenta