*: Chunkreuse try reuse chunk in operator #38607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: distsql/select_result.go
modified: executor/adapter.go
modified: executor/admin.go
modified: executor/aggregate.go
modified: executor/builder.go
modified: executor/coprocessor.go
modified: executor/cte.go
modified: executor/delete.go
modified: executor/distsql.go
modified: executor/executor.go
modified: executor/explain.go
modified: executor/index_lookup_hash_join.go
modified: executor/index_lookup_join.go
modified: executor/index_lookup_merge_join.go
modified: executor/index_merge_reader.go
modified: executor/insert_common.go
modified: executor/join.go
modified: executor/joiner.go
modified: executor/merge_join.go
modified: executor/parallel_apply.go
modified: executor/pipelined_window.go
modified: executor/projection.go
modified: executor/select_into.go
modified: executor/show.go
modified: executor/shuffle.go
modified: executor/sort.go
modified: executor/union_scan.go
modified: executor/update.go
modified: executor/window.go
modified: server/conn.go
modified: sessionctx/variable/session.go
modified: sessionctx/variable/sysvar.go
modified: sessionctx/variable/tidb_vars.go
modified: util/chunk/alloc.go
modified: util/chunk/alloc_test.go
modified: util/chunk/chunk.go
…into chunkreuse Conflicts: executor/adapter.go executor/aggregate.go executor/builder.go executor/coprocessor.go executor/distsql.go executor/executor.go executor/join.go executor/projection.go executor/union_scan.go executor/update.go sessionctx/variable/session.go util/chunk/alloc.go modified: executor/executor.go modified: executor/index_lookup_merge_join.go modified: sessionctx/variable/session.go
modified: executor/parallel_apply.go modified: sessionctx/variable/session.go modified: util/chunk/alloc.go modified: util/chunk/chunk.go
modified: executor/admin.go modified: executor/aggregate.go modified: executor/distsql.go modified: executor/executor.go modified: executor/index_lookup_hash_join.go modified: executor/index_lookup_join.go modified: executor/index_lookup_merge_join.go modified: executor/index_merge_reader.go modified: executor/join.go modified: executor/joiner.go modified: executor/pipelined_window.go modified: server/conn.go
modified: sessionctx/variable/sysvar.go modified: sessionctx/variable/tidb_vars.go modified: util/chunk/alloc.go
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
ti-chi-bot
removed
the
needs-rebase
|
@keeplearning20221 Please fix the linter. |
modified: util/chunk/alloc.go modified: util/chunk/chunk.go
modified: util/chunk/chunk.go
modified: sessionctx/variable/tidb_vars.go
modified: executor/index_lookup_merge_join.go modified: util/chunk/alloc_test.go
modified: util/chunk/alloc_test.go
|
/run-build |
|
/run-unit-test |
|
/run-build |
modified: sessionctx/variable/session_test.go modified: util/chunk/alloc.go modified: util/chunk/alloc_test.go modified: util/chunk/chunk_test.go
ti-chi-bot
added
the
needs-rebase
modified: infoschema/tables_test.go modified: sessionctx/variable/BUILD.bazel modified: testkit/BUILD.bazel modified: tidb-server/BUILD.bazel
cfzjywxk
approved these changes
Nov 3, 2022
ti-chi-bot
added
status/LGT2
|
/build-release |
|
/release |
We can change to disable by default if we find anything wrong during test. |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 0ceee0d
|
ti-chi-bot
added
the
status/can-merge
|
/run-build |
|
/run-check_dev_2 |
|
/run-mysql-test |
|
/run-unit-test |
|
/run-check_dev_2 |
TiDB MergeCI notify✅ Well Done! New fixed [2] after this pr merged.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #38606
Problem Summary:
Every time chunk is used, it will be applied from the system, which affects the execution efficiency of tidb-server.
What is changed and how it works?
Cache previously applied chunks and columns in alloc.later, it will get chunk from cache first , if not enough then apply from system.
Alloc modified based on the alloc developed by tiancaiamao. It uses slices to manage chunks objects and columns objects. When used, they are taken out of free slices and placed in allocated slices.When the SQL execution is complete, put it back from the allocated slice back to the free slice.
Add configuration items
tidb_enable_reuse_chunk function switch
tidb_max_reuse_chunk Maximum number of cached chunks
tidb_max_reuse_column Maximum number of cached columns
Add read-only variable：
Last_sql_use_alloc Whether the previous sql uses chunk alloc
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.