Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Geospatial support #38611

Draft
wants to merge 35 commits into
base: master
Choose a base branch
from
Draft

*: Geospatial support #38611

wants to merge 35 commits into from
+11,127 −10,569

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Oct 23, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #6347

Problem Summary:

What is changed and how it works?

  • GEOMETRY data type
  • ST_GeomFromText() function
  • ST_AsText() function
  • ST_Distance() function (restricted to SRID 0 for now)

This works with the unistore. To work with TiKV this PR is needed: tikv/tikv#13652

This adds github.com/twpayne/go-geom as a dependency.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support for the `GEOMETRY` data type and an initial set of geospatial functions was added

@dveeden
WIP: geospatial
4d7fcf3 
- `GEOMETRY` data type
- `ST_GeomFromText()` function
- `ST_AsText()` function
- `ST_Distance()` function
- `ST_Intersects()` function
@dveeden
Fix ST_Intersects() to work on typs other than just points
37acd44
@dveeden
Small fixes
ff673e2
@dveeden
stGeomFromTextFunctionClass: check number of arguments
dc25b35
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 23, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2022
@dveeden
Copy link
Contributor Author

dveeden commented Oct 23, 2022

/run-build
/run-mysql-test
/run-unit-test

@ngaut
Copy link
Member

ngaut commented Oct 23, 2022

Cool.

@dveeden
Copy link
Contributor Author

dveeden commented Oct 24, 2022

/run-all-tests

@dveeden
Copy link
Contributor Author

dveeden commented Oct 24, 2022

/run-mysql-test

@dveeden
Copy link
Contributor Author

dveeden commented Oct 25, 2022

/run-unit-test

@dveeden dveeden marked this pull request as ready for review October 25, 2022 10:08
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2022
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 5, 2022
@dveeden dveeden marked this pull request as draft December 6, 2022 06:39
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2022
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 7, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 27, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2023
mjonss
mjonss reviewed Jan 19, 2023
View reviewed changes
parser/ast/ddl.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2023
@mjonss mjonss mentioned this pull request Jan 23, 2023
Draft
1 task
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2023
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2023
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2023
@ti-chi-bot
Copy link
Member

@dveeden: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 10, 2024

@dveeden: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev a349b45 link true /test check-dev
idc-jenkins-ci-tidb/build a349b45 link true /test build
idc-jenkins-ci-tidb/check_dev_2 a349b45 link true /test check-dev2
pull-mysql-client-test a349b45 link true /test pull-mysql-client-test
idc-jenkins-ci-tidb/mysql-test a349b45 link true /test mysql-test
pull-integration-ddl-test a349b45 link true /test pull-integration-ddl-test
idc-jenkins-ci-tidb/unit-test a349b45 link true /test unit-test
pull-br-integration-test a349b45 link true /test pull-br-integration-test
pull-lightning-integration-test a349b45 link true /test pull-lightning-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codingbugss
Copy link

no good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjonss mjonss mjonss left review comments

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees
No one assigned
Labels
component/expression do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dveeden @ti-chi-bot @ngaut @codingbugss @mjonss